Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#92 Join command still not functioning

1.94
closed
1
2014-05-04
2014-05-01
Anonymous
No

The join command, which says has been fixed in the bug notes, still doesn't work. Says invalid command. Rendering this build useless for what I need. Any ideas on how to fix this issue? I tried commenting out the JS quick validation, no go.

Discussion

1 2 3 > >> (Page 1 of 3)
  • Jordan T
    Jordan T
    2014-05-01

    Woops, wasn't logged in. Post by me.

     
    • http://ciprianmp.com/plus/ - the demo is working fine.
      Send me a link to your chat so I can visit and replicate.

      PS: the validation is in lib/commands.lib.php - if you wish to look into it yourself.

       
      • Jordan T
        Jordan T
        2014-05-02

        Did you actually try the /join command? I've tried now on every browser that is available, here in 2014, it doesn't work man....

         
  • Jordan T
    Jordan T
    2014-05-01

    I have looked, the command is there, and regex should be fine. It's the JS validator that's throwing the prompt and preventing submit. I'll have to move the chat to a host, it's currently offline. Give m a bit.

    Update: It should be available at http://wasasquatch.strangled.net/PHPMyChat/

     
    Last edit: Jordan T 2014-05-01
  • Jordan T
    Jordan T
    2014-05-01

    And like I said, I commented out the entire JS quick validator in index.lib.php but it still prompts the same message and doesn't submit.

    Update: Turned off required registrations

    Could this be a Google Chrome issue with JavaScript? If so, that's bad.

     
    Last edit: Jordan T 2014-05-01
  • Jordan T
    Jordan T
    2014-05-02

    I tried your demo, it also does not let you use /join as it should (join a room or create it), this must be a incompatibility with Google Chrome.

    This is interesting considering PHPMyChat (the original build, like this modified version http://nexxushost.com/rpg/thekeep) allows you to use it just fine, and it's the same legacy JS as far as I know in that modified version.

    Edit: Actually, doesn't work in Firefox either. Lol

    Firefox

    Chrome

    I've tried creating rooms, with, and without passwords, I've tried going to public rooms, nothing works with the command what so ever.

     
    Last edit: Jordan T 2014-05-02
    • You are wrong. It works just fine on my end with Chrome. I am sure it works with any other browser as well.
      Are you sure your browser settings allow javascript to be run?
      That's the only reason I could think of right now.
      The command format is:
      /join 1 #room name
      Or
      /join 0 #room name
      (Last for private rooms)

      It allowed me to create new rooms as well as joining existing ones. Something is wrong on your end only... Sorry.

       
      • Jordan T
        Jordan T
        2014-05-02

        Oh, you killed the join command. What the heck is that nonsense? Deliminating one or zero for private? The password took care of that. So there is essentially no custom user rooms anymore of appropriate nature where only certain people with the pass can join? Lol

        You have to remember, humans are typing the commands. Not a machine, they won't automatically understand the 1 or 0, even by reading the directions. They want to use plain english, hence english/language based commands.

        I might just need to update the original PHPMyChat. You've sort of butchered the chat. :\

        While expecting donations and plastering copyrights and donation links all over the chat, which is originally a completely free chat to do with as you please, include removing any copyright notice. Kinda going against the the reason PHPMyChat was included in WHM and cPanel in the past.

        You might want to note there is no custom private rooms anymore, only public private rooms to those users with super perms. Anyone with those perms can access any private room. No more meeting rooms, secret hideouts, just straight open to any of those users.

         
        Last edit: Jordan T 2014-05-02
    • Here it is: http://ciprianmp.com/plus/lurking.php
      ... Proof I was there. Even from Chrome on my HTC One...

       
    • And your own setup is working just fine, so stop messing with the code before you make sure it's a bug.... Lol
      http://wasasquatch.strangled.net/PHPMyChat/lurking.php
      I have created that room using join in your chat.

       
1 2 3 > >> (Page 1 of 3)


Anonymous


Cancel   Add attachments