#729 (ok 4.0) Contest-2 Show index information in the data dict.

closed-fixed
Marc Delisle
1
2013-05-09
2012-03-17
Muhammad Adnan
No

attached is the patch.

Discussion

  • Marc Delisle
    Marc Delisle
    2012-03-17

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2012-03-17

    • status: open --> pending-rejected
     
  • Marc Delisle
    Marc Delisle
    2012-03-17

    Thanks for the patch, but I cannot accept it.

    There is code duplication with other parts of the code which already display the index information in other pages.

     
  • Muhammad Adnan
    Muhammad Adnan
    2012-03-20

    hey @lem9
    I was sick and couldn't reply on my patch. I'm just back to my routine. I will reply about this patch soon.

     
  • Muhammad Adnan
    Muhammad Adnan
    2012-03-21

    Please have a look at code now. It is not duplicated.

     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    • status: pending-rejected --> open-rejected
     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    • status: open-rejected --> open
     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    This is better, but
    1. please provide a patch that applies to current master
    2. avoid showing the index section for a table that has no index

     
  • Muhammad Adnan
    Muhammad Adnan
    2012-03-22

    1. please provide a patch that applies to current master
    ok will do it

    2. avoid showing the index section for a table that has no index
    Currently it shows index section and displays that "No index defined!"
    We shouldn't show this ?

     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    About #2, indeed it takes unnecessary room in the report.

     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    From ee75ab459e86915b2a0dff794c8ad6b404c564b0 Mon Sep 17 00:00:00 2001
    From: Muhammad Adnan <hiddenpearls@gmail.com>
    Date: Thu, 22 Mar 2012 23:01:14 +0500
    Subject: [PATCH] Contest-2: Show indexes information in data dictionary

    ---
    db_datadict.php | 8 +++++++-
    1 files changed, 7 insertions(+), 1 deletions(-)

    diff --git a/db_datadict.php b/db_datadict.php
    index e57206f..46f4b80 100644
    --- a/db_datadict.php
    +++ b/db_datadict.php
    @@ -22,7 +22,7 @@ if (! isset($selected_tbl)) {
    $cfgRelation = PMA_getRelationsParam();

    require_once 'libraries/transformations.lib.php';
    -
    +require_once 'libraries/Index.class.php';

    /**
    * Check parameters
    @@ -262,6 +262,12 @@ foreach ($tables as $table) {
    $count++;
    ?>
    </table>
    +<?php
    +// display indexes information
    + if(count(PMA_Index::getFromTable($table, $db))>0){
    + echo PMA_Index::getView($table, $db,true);
    + }
    +?>
    </div>
    <?php
    } //ends main while
    --
    1.7.5.4

     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    Your patch was merged in the repository, thanks.

     
  • Marc Delisle
    Marc Delisle
    2012-03-22

    • summary: Contest-2 Show index information in the data dictionary --> (ok 4.0) Contest-2 Show index information in the data dict.
    • priority: 5 --> 1
    • status: open --> open-accepted
     
  • Michal Čihař
    Michal Čihař
    2013-05-09

    • Status: open-accepted --> closed-fixed