Codemirror gets activated in querywindow to have the full effect of syntax highlightning in all places.
Thanks for the patch.
When I try it on master, it causes a problem: I can no longer submit a query (I get "Missing value in the form")
I did the patch against last git master yesterday. How did you do it?
This works for me:
1. Browse a table
2. Click edit for the query
3. Add some where-argument to the query
4. Click Go
I noticed the codemirror is not active when doing an inline edit as well, will see whats needed for that.
I'm also testing with current master. Your scenario works for me too.
What does not work for me is:
1. click on a db name (not a table name)
2. click on the query window icon from the navigation (left) panel
3. enter a query like "select * from actor"
4. click on Go
Ah, thanks for the testing, I'll fix that and get back with a new patch.
lem9, check patch query_window_codemirror_20120203.patch, it works for the scenario you describe as well. Thanks for testing.
Your patch was merged in the repository, thanks.
Alex Marin found a problem with this patch, see his comment:
any progress on this?
I'm having trouble reproducing this, tried it on latest master from github as suggested in the wiki.
Last commit is bfd24b8a24105c0b0744ae2fcbcfdae8c9434460
with the latest master having the same last commit as you, I can reproduce under Firefox 9.0.1 (Windows XP) the problem mentioned by Alex:
"some_database ->some_table -> SQL tab -> press go on the "Run SQL query/queries on database some_database" form
nothing will happen, the form will not be submitted."
Did you clear your browser's cache?
Hi again, quick reply! :)
I tried this:
"some_database(left frame) ->some_table(tried both left and right frame) -> SQL tab(at the top of the right frame, right?) -> press go on the "Run SQL
query/queries on database some_database"
Just tried it in Firefox 9.0.1(normally use chrome) on linux, emptied the cache first, but no luck. :/
query/queries on database some_database
Yes, it's the SQL tab in the right frame. I can also reproduce the problem on http://demo.phpmyadmin.net/master login with root and no password, choose the sakila db, then the actor table, then click SQL on the right panel. The query appears, clicking on Go produces nothing but an error in Firebug.
Ah, found the problem. I noticed I've disabled ajax on my installation, Home -> Settings -> General -> Enable ajax.
If you disable ajax the submit works, not much better though. At least I can reproduce it, let me check if a fix is simple. :)
Fixes problem with ajax querywindow described in comment Date: 2012-02-14 13:18:07 PST
New patch posted that fixes the problem, fixed-ajax-querywindow-codemirror-problem-20120214.patch
New patch accepted, thanks.