#674 (ok 3.5) Add edit view link

closed-accepted
Interface (183)
1
2012-04-07
2011-08-01
No

It would be nice to have an edit view link on the tbl_structure page. This way it's possible to see the query behind it or even change it more easily.

I implemented a first draft.

Pull: git://github.com/csware/phpmyadmin.git edit-view

Discussion

1 2 > >> (Page 1 of 2)
  • Michal Čihař
    Michal Čihař
    2011-08-02

    Your code does not seem to work with any table in sakila example database I've tried, so there must be something broken.

     
  • Works here. Do you get any error message?

     
  • Did you pull the complete history of my branch? (2 commits)

     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    • assigned_to: nobody --> nijel
     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    I see no errors, but for example when editing view "customer_list" I get default SQL query instead of the one defining view: SELECT * FROM `customer_list` WHERE 1

     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    And yes, I did pull both commits.

     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    Ah okay, the issue is coming from Suhosin blocking the request, you should use PMA_linkOrButton instead of directly creating link, because the query can be quite long here.

     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    • summary: Add edit view link --> (ok 3.5) Add edit view link
    • status: open --> open-accepted
     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    Okay, I did that myself :-). Thanks for the patch, merged in git.

     
  • Michal Čihař
    Michal Čihař
    2011-08-08

    • priority: 5 --> 1
     
1 2 > >> (Page 1 of 2)