Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#599 (ok 3.4.0-rc1) Fix for the (un)checkall butons in privileges

closed-accepted
Marc Delisle
Interface (183)
1
2011-04-16
2011-03-26
Rouslan Placella
No

Hi,

I had a go at fixing the ''checkaII'' bug in the user privilege dialogs (bug #3188444). It occurs because every element id on the page must be unique, but all the forms are assigned the same id, namely ''addUsersForm''. The ''Add a new User'' dialog is also affected by this, as well as all db-specific permission dialogs. I have created a patch that appends a large random number to the ids of forms. While maybe not the best solution, it does work. A better way to fix this may be to instead use a counter (or maybe even the token), but I didn't
manage to implement that. Please find the patch attached.

Regards, Rouslan

Discussion

  • Marc Delisle
    Marc Delisle
    2011-03-26

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2011-03-26

    Your patch was merged in the repository, thanks.

     
  • Marc Delisle
    Marc Delisle
    2011-03-26

    • priority: 5 --> 1
    • summary: Fix for the '(un)checkall' butons in privileges --> (ok 3.4.0-rc1) Fix for the (un)checkall butons in privileges
    • status: open --> open-accepted
     
  • Thanks for letting me know.
    I'm on it and will have a fix ASAP.

    Rouslan

     
  • Marc Delisle
    Marc Delisle
    2011-04-16

    • status: open-accepted --> closed-accepted