Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#584 (ok 3.4.0-beta4) Ajaxify browse/delete criteria in DB search

closed-accepted
Marc Delisle
None
1
2011-03-12
2011-02-09
Anonymous
No

Modified the Browse criteria and delete criteria of database search to loads in the same window of the search results load.

Discussion

  • Marc Delisle
    Marc Delisle
    2011-02-09

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    Thanks for the patch. There are a few issues:

    1. in db_search.php you are using <? instead of <?php
    2. when I do "git apply" I have a few "space before tab in indent" warnings
    3. even when fixing #2, clicking on Browse in the search results does nothing

    As this patch's goal is supposed to evaluate your potential, I won't give other advice about how to fix these problems, but I'm available to test your next version.

     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    • status: open --> pending
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    • status: pending --> open
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    About #3, it happens when Ajax is disabled by the user (this was my case), see $cfg['AjaxEnable'].

    Apart from this, the patch works pretty well.

     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    I think we would need a "Hide search results" and "Show search results" as well.

     

  • Anonymous
    2011-02-10

    Marc,
    Thanks for the suggestions and comments. I'll focus on those issues and fix them as soon as possible.

     
  • Marc Delisle
    Marc Delisle
    2011-02-14

    I tried again #3 and this time it worked correctly, but it should not have worked because AjaxEnable was false.

     
  • Marc Delisle
    Marc Delisle
    2011-02-20

    • status: open --> pending
     

  • Anonymous
    2011-02-26

    • status: pending --> open
     

  • Anonymous
    2011-02-26

    Marc,
    I fixed the issue #1, #2 and #3 you have raised. I'll add the "Hide search results" and "Show search results option as soon as possible.

     
  • Marc Delisle
    Marc Delisle
    2011-02-26

    Thilanka,
    in your second patch, I cannot find a reference to the AjaxEnable parameter. This means that the Ajax behavior of showing, for example, the browse results at the bottom of the page, works even if the user asked for no Ajax behavior.

    Also, please do not use tab characters in the patch; we use spaces.

     
  • Marc Delisle
    Marc Delisle
    2011-02-26

    • status: open --> pending
     

  • Anonymous
    2011-02-28

    Marc,
    Thanks for the clarification. I just got the point now. I fixed it by checking the Ajax enabled with my third patch.
    Also I have changed the tabs to spaces. Please can you check this.

     

  • Anonymous
    2011-02-28

    • status: pending --> open
     
  • Marc Delisle
    Marc Delisle
    2011-02-28

    Patch accepted, thanks. I deactivated the two new messages as we are now in message freeze for the 3.4 release.

     
  • Marc Delisle
    Marc Delisle
    2011-02-28

    • summary: Ajaxify browse and delete criteria in DB search --> (ok 3.4.0-beta4) Ajaxify browse/delete criteria in DB search
    • priority: 5 --> 1
    • status: open --> open-accepted
     

  • Anonymous
    2011-03-01

    Thank you Marc.

     
  • Marc Delisle
    Marc Delisle
    2011-03-12

    • status: open-accepted --> closed-accepted