#584 (ok 3.4.0-beta4) Ajaxify browse/delete criteria in DB search

closed-accepted
Marc Delisle
None
1
2011-03-12
2011-02-09
Anonymous
No

Modified the Browse criteria and delete criteria of database search to loads in the same window of the search results load.

Discussion

1 2 3 > >> (Page 1 of 3)
  • Marc Delisle
    Marc Delisle
    2011-02-09

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    Thanks for the patch. There are a few issues:

    1. in db_search.php you are using <? instead of <?php
    2. when I do "git apply" I have a few "space before tab in indent" warnings
    3. even when fixing #2, clicking on Browse in the search results does nothing

    As this patch's goal is supposed to evaluate your potential, I won't give other advice about how to fix these problems, but I'm available to test your next version.

     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    • status: open --> pending
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    • status: pending --> open
     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    About #3, it happens when Ajax is disabled by the user (this was my case), see $cfg['AjaxEnable'].

    Apart from this, the patch works pretty well.

     
  • Marc Delisle
    Marc Delisle
    2011-02-09

    I think we would need a "Hide search results" and "Show search results" as well.

     

  • Anonymous
    2011-02-10

    Marc,
    Thanks for the suggestions and comments. I'll focus on those issues and fix them as soon as possible.

     
  • Marc Delisle
    Marc Delisle
    2011-02-14

    I tried again #3 and this time it worked correctly, but it should not have worked because AjaxEnable was false.

     
  • Marc Delisle
    Marc Delisle
    2011-02-20

    • status: open --> pending
     
1 2 3 > >> (Page 1 of 3)