#513 (ok 3.4) Patch for Use inline query editing - ID: 2804874

closed-accepted
Interface (183)
1
2011-05-11
2010-03-31
Muhammad Adnan
No

Use inline query editing - ID: 2804874

Discussion

  • Muhammad Adnan
    Muhammad Adnan
    2010-03-31

    Inline_editing_query

     
    Attachments
  • Michal Čihař
    Michal Čihař
    2010-03-31

    Thanks for the patch, however I see several problems with it:

    - The inline edit link should be displayed only with javascript enabled
    - Save/Discard should rather be buttons instead of links
    - Discard link replaces query value with null
    - The editing textarea is too small, it should probably fit into available area or at least use same dimensions as separate SQL textarea uses

     
  • Muhammad Adnan
    Muhammad Adnan
    2010-03-31

    fixes-done

     
    Attachments
  • Muhammad Adnan
    Muhammad Adnan
    2010-03-31

    Thanks for the issues pointed. I jut fixed them.
    Let me know if something problem still.

     
  • Muhammad Adnan
    Muhammad Adnan
    2010-04-01

    Final Inline Query Editing Patch

     
    Attachments
  • Muhammad Adnan
    Muhammad Adnan
    2010-04-01

    I fixed the style issue and uppercase HTML. Hope it works now.

     
  • Michal Čihař
    Michal Čihař
    2010-04-01

    Merged in Git, however it required still some cleanup.

     
  • Michal Čihař
    Michal Čihař
    2010-04-01

    • priority: 5 --> 1
    • assigned_to: nobody --> nijel
    • summary: Patch for Use inline query editing - ID: 2804874 --> (ok 3.4) Patch for Use inline query editing - ID: 2804874
     
  • Michal Čihař
    Michal Čihař
    2010-04-07

    • status: open --> open-accepted
     
  • Michal Čihař
    Michal Čihař
    2011-05-11

    • status: open-accepted --> closed-accepted