Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#471 (ok 3.3) Filter of tables displayed for open DB

closed-accepted
Marc Delisle
1
2010-03-07
2009-05-21
dylfin
No

Displayed tables in open DB will be filtered by keyword entered in text box

Discussion

  • Marc Delisle
    Marc Delisle
    2009-05-21

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2009-05-21

    Interesting idea. However with the HTML validator, I get an error about onKeyUp being non XHTML compliant (there is no such attribute), can you work on this?

     
  • dylfin
    dylfin
    2009-05-22

    Updated.

     
  • Marc Delisle
    Marc Delisle
    2009-05-23

    Great. Two more things about which I would appreciate your comments (I can manage to implement those):

    1. I would add to the input field a hint, for example title="filter" (which would be localized of course).

    2. What should happen when js is disabled? I propose to not display this input field at all ( see in tbl_change.php what we do in these situations, using document.write).

     
  • dylfin
    dylfin
    2009-05-23

    Filter of tables displayed for open DB

     
    Attachments
  • dylfin
    dylfin
    2009-05-23

    Updated.
    Added two lang vars for English and Russian.
    Maybe style display:none is better then document write?

     
  • Marc Delisle
    Marc Delisle
    2009-05-24

    • priority: 5 --> 1
    • summary: Filter of tables displayed for open DB --> (ok 3.3) Filter of tables displayed for open DB
    • status: open --> open-accepted
     
  • Marc Delisle
    Marc Delisle
    2009-05-24

    Agreed. Merged for 3.3, thanks. Please send more patches ;)

     
  • dylfin
    dylfin
    2010-01-22

    I changed filter input box width to 100% of frame.

     
  • Marc Delisle
    Marc Delisle
    2010-01-22

    Thanks. With this patch the X (for reset) no longer seem to work (at least under Internet Explorer 8). Maybe we could remove this X anyway?

     
  • dylfin
    dylfin
    2010-01-25

    Filter field width fix

     
  • dylfin
    dylfin
    2010-01-25

    I almost don't use IE8, get tired to fight with it. I use button X in work, so I can't consider it as useless. I updated it for IE and add text select on input field focus event.

     
  • Marc Delisle
    Marc Delisle
    2010-01-25

    Latest patch merged for the release after 3.3.0-beta1, thanks!

     
  • dylfin
    dylfin
    2010-03-02

    'X' changed after revision 13426

     
    Attachments
  • Marc Delisle
    Marc Delisle
    2010-03-07

    • status: open-accepted --> closed-accepted