#235 (in 2.6.3) JS error in alter_table & more with mySQL<4.1.2

closed-fixed
Interface (183)
1
2005-07-03
2005-06-22
php-sourcerer
No

version 2.6.2-pl1

tbl_properties.inc.php
defines JS function 'display_field_options if
PMA_MYSQL_INT_VERSION >= 40102
which is called regardless of the mySQL version.

and "value" is not (officialy) an attribute of "select"
elements; so
this.options[this.selectedIndex].value
should be preferred to
this.value

replace line 236 with this:
$content_cells[$i][$ci] = '<select name="field_type[]"
id="field_' . $i . '_' . ($ci - $ci_offset) . '"'.
(PMA_MYSQL_INT_VERSION >= 40102 ? '
onchange="display_field_options(this.options
[this.selectedIndex].value,' . $i .')"' : ''). ' >' . "\n";

Discussion

  • Garvin Hicking
    Garvin Hicking
    2005-06-22

    • priority: 5 --> 1
    • assigned_to: nobody --> garvinhicking
    • summary: JS error in alter_table & more with mySQL<4.1.2 --> (in 2.6.3) JS error in alter_table & more with mySQL<4.1.2
    • status: open --> open-fixed
     
  • Garvin Hicking
    Garvin Hicking
    2005-06-22

    Logged In: YES
    user_id=473563

    Why do you say that the statement is called regardless of
    PMA_MYSQL_INT_VERSION? The check you changed it into
    virtually does the same if check, so I don't see what it
    would do differently - could you elaborate on this, please?

    About the JS hint, thanks a lot, I have committed the patch!

     
  • php-sourcerer
    php-sourcerer
    2005-06-22

    Logged In: YES
    user_id=1301017

    oops ...
    I see its fixed in the current RC.
    sorry for not checking that one first.
    I will next time.

     
  • Marc Delisle
    Marc Delisle
    2005-07-03

    • status: open-fixed --> closed-fixed