#1288 (ok 3.5) SQL syntax highlighting

fixed
1
2013-06-11
2011-02-18
Nicolas Toniazzi
No

I thought it would be interesting to have a syntax highlighter in the SQL query window. I made a quick patch to add CodeMirror (http://codemirror.net/).
Before submitting a patch, I'd like to know I there are some rules concerning the use of external libraries, and where to put them in the source tree.

Discussion

  • Marc Delisle
    Marc Delisle
    2011-02-18

    Licensing rule: must be GPL 2 compatible.

     
  • Actually I don't. I tried to find something easy to use as a developer, and found CodeMirror. The result was satisfying enough for me.
    So unfortunately I don't have any objective comparing information, but I think they could be defined as plugins and used alternatively. I managed to add CodeMirror in an almost non-intrusive way. It was for an older version of phpmyadmin and I need to change some things then I will submit a patch.

     
  • Michal Čihař
    Michal Čihař
    2011-03-02

    We anyway need to choose "the best" solution to provide by default.

    The editArea looked also pretty easy to integrate when I tried, but I have not found enough time to prepare it for 3.4 release.

     
  • Michal Čihař
    Michal Čihař
    2011-06-02

    • assigned_to: nobody --> nijel
     
  • Michal Čihař
    Michal Čihař
    2011-06-02

    • priority: 5 --> 1
    • summary: SQL syntax highlighting --> (ok 3.5) SQL syntax highlighting
    • status: open --> open-fixed
     
  • Michal Čihař
    Michal Čihař
    2011-06-02

    CodeMirror2 is now being used in git.

     
  • Marc Delisle
    Marc Delisle
    2012-04-07

    • status: open-fixed --> closed-fixed
     
  • Michal Čihař
    Michal Čihař
    2013-06-11

    • Status: closed-fixed --> fixed