#4133 (ok 4.1.0-rc1) CSV import breaks when no blank line at end of file

4.0.8
fixed
Marc Delisle
None
1
2013-12-12
2013-10-14
DisgruntledGoat
No

If you import a CSV that does not end with a trailing new line, it comes back with an error: "Invalid format of CSV input on line 25."

And the last line of the CSV is not imported. This is a basic CSV as exported from Google Docs.

Discussion

  • Update: this worked fine with another CSV. The ones it fails on are when the last line has blank data, for example this 3 column table:

    1,test,Q
    2,tests,W
    3,testh,E
    4,testt,R
    5,testu,

     
  • slimtim
    slimtim
    2013-11-20

    Sorry, Hugues. I didn't see that you submitted a pull request until after I issued mine.

     
  • Marc Delisle
    Marc Delisle
    2013-11-21

    • summary: CSV import breaks when no blank line at end of file --> (ok 4.1.0-beta3) CSV import breaks when no blank line at end of file
    • status: open --> resolved
    • assigned_to: Marc Delisle
    • Priority: 5 --> 1
     
  • Marc Delisle
    Marc Delisle
    2013-11-23

    • summary: (ok 4.1.0-beta3) CSV import breaks when no blank line at end of file --> (ok 4.1.0-rc1) CSV import breaks when no blank line at end of file
     
  • Marc Delisle
    Marc Delisle
    2013-12-12

    • Status: resolved --> fixed