#4069 (ok 4.0.6) Navigation tree height not set correctly dynamically

Latest_Git_snapshot
fixed
Ann + J.M.
1
2013-08-26
2013-08-26
Ann + J.M.
No

As seen in: RELEASE_4_0_5RC1-132-gc2e5b11

Related to RFE 1435.

Expanding a database in the navigation tree does not use the available content height. See photo attachment.

73c3cd906e484c75f19039bd4086daa3fd62b8fa is the first bad commit
commit 73c3cd906e484c75f19039bd4086daa3fd62b8fa
Author: Atul Pratap Singh atulpratapsingh05@gmail.com
Date: Sun Aug 25 22:55:43 2013 +0530

Fast-filter box, recent-tables and page-selector should be visible while scrolling navigation, (it eliminates the need to scroll up to find datatbase/recent-table)

:040000 040000 b0932962b384b4f6ca38a479500ac14217897c37 4a1be0339d747e768255370ec8e9551f1208c3cc M js
:040000 040000 7cc4b0f1bc9dabcf74a01867fbed1fc15c210a38 5bdb858733a846ed13ff53764a54e6be5657ba1d M libraries
:040000 040000 b8a96db5ff3d6fdd226ef224a0a89839fddefea5 43a2413552dcace7456faea3635e4636a25c7c47 M themes

Apparently it was forgotten to set the height of #pma_navigation_tree dynamically, opposed to what is commented in the CSS.

/* Navigation tree */
#pma_navigation_tree {
    margin: 5px 0 0;
    margin-<?php echo $left; ?>: 10px;
    color: #444;
    height: 74%; /*it needs to be dynamically set*/
    position: relative;
}
1 Attachments

Discussion

  • Ann + J.M.
    Ann + J.M.
    2013-08-26

    Fix does not need any ChangeLog entry, bug was not present in any released version.

     
  • Ann + J.M.
    Ann + J.M.
    2013-08-26

    • summary: Navigation tree height not set correctly dynamically --> (ok 4.0.6) Navigation tree height not set correctly dynamically
    • status: open --> fixed
    • assigned_to: Atul Pratap Singh --> J.M.
    • Priority: 7 --> 1
     
  • Ann + J.M.
    Ann + J.M.
    2013-08-26

    Fixed with 9daaa1d.