#3919 (ok 4.0.2) PropertiesIconic not honored

4.0.0
fixed
nobody
None
1
2013-06-11
2013-05-09
Isaac Bennetch
No

Setting $cfg['PropertiesIconic'] doesn't seem to have any effect.

Discussion

  • Ann + J.M.
    Ann + J.M.
    2013-05-11

    • status: open --> pending-works-for-me
    • Priority: 5 --> 4
     
  • Ann + J.M.
    Ann + J.M.
    2013-05-11

    Can't reproduce on QA_4_0-8fd07ac. Can you provide steps?

     
  • Isaac Bennetch
    Isaac Bennetch
    2013-05-12

    Just re-tested on the demo server and my own server, both with 78c8b11 from the current master branch, previously tested with the master branch from a few days prior,

    Two ways to test:
    1) In config.inc.php, add the line $cfg['PropertiesIconic'] = true;

    2) From the main page, click the Settings tab, then Main Panel, and finally Browse Mode. At the second option (Iconic table operations) select "Yes"

    After applying the settings, view the main page or any database page. The expected result is to see only the icon in the tabs across the top of the page, but I still continue to see both icons and text.

    Setting the values to false or No should show only text, no icons, and also fails to do so.

    The pull request https://github.com/phpmyadmin/phpmyadmin/pull/361 does fix it for me.

     
  • Ann + J.M.
    Ann + J.M.
    2013-05-14

    • status: pending-works-for-me --> pending-fixed
     
  • Ann + J.M.
    Ann + J.M.
    2013-05-14

    Will backport.

     
  • Ann + J.M.
    Ann + J.M.
    2013-05-14

    • summary: PropertiesIconic not honored --> (ok 4.0.2) PropertiesIconic not honored
    • status: pending-fixed --> open-fixed
    • Priority: 4 --> 1
     
  • Marc Delisle
    Marc Delisle
    2013-05-24

    • Status: open-fixed --> closed-fixed
     
  • Michal Čihař
    Michal Čihař
    2013-06-11

    • Status: closed-fixed --> fixed