#3917 CountTables seems broken

4.0.0
wont-fix
Marc Delisle
None
5
2013-06-11
2013-05-08
Isaac Bennetch
No

It seems as if the CountTables configuration option doesn't work anymore.

Git tells me the first bad commit was 69b81e "Added ajax-loaded navigation to the main page" by Rouslan, although I got a blank page during my git bisect so wasn't able to test that particular revision.

Discussion

  • I deliberately removed display of the number of tables in version 4.0. The queries are already very slow as they are. The rationale was that the navigation is for navigating, not gathering information about the databases.

    If that's the only place where that config option is used, I'd rather see that removed instead...

     
  • Isaac Bennetch
    Isaac Bennetch
    2013-05-09

    That makes sense, but a user was asking about it so I wonder how many people would miss it. Since that code is currently removed, probably the best solution is to remove that configuration option and associated documentation, plus document the depreciation in the release notes. It's not something I feel strongly about keeping or removing.

     
  • I also agree that CountTables configuration should be dropped.

     
  • Marc Delisle
    Marc Delisle
    2013-05-20

    • assigned_to: Marc Delisle
     
  • Marc Delisle
    Marc Delisle
    2013-05-20

    Please review https://github.com/phpmyadmin/phpmyadmin/pull/398.

    Update: this pull request has been implemented, removing the CountTables directive.

     
    Last edit: Marc Delisle 2013-05-21
    • status: open --> closed-wont-fix
     
  • Michal Čihař
    Michal Čihař
    2013-06-11

    • Status: closed-wont-fix --> wont-fix