#3699 (ok 3.5.4) Incorrect imagejpeg Syntax Breaks Image Transf.

3.5.3
fixed
Marc Delisle
1
2013-06-11
2012-10-15
Magotchi
No

In newer versions of PHP, due to incorrect syntax for the imagejpeg function in transformation_wrapper.php, image resizing breaks (outputs no image data).

The line that reads:
ImageJPEG($destImage, '', 75);

Should be:
ImageJPEG($destImage, NULL, 75);

as per the documentation at http://php.net/manual/en/function.imagejpeg.php .

The current way works fine on my server with PHP 5.3.8, but not on my server with PHP 5.4.6, but I'm not sure on the exact version cutoff.

Discussion

  • Magotchi
    Magotchi
    2012-10-15

    • summary: Incorect imagejpeg Syntax Breaks Image Transformation --> Incorrect imagejpeg Syntax Breaks Image Transformation
     
  • Marc Delisle
    Marc Delisle
    2012-10-16

    • assigned_to: nobody --> lem9
     
  • Marc Delisle
    Marc Delisle
    2012-10-16

    Good catch!
    Fixed for 3.5.4, thanks.

     
  • Marc Delisle
    Marc Delisle
    2012-10-16

    • milestone: 284140 --> 3.5.3
    • priority: 5 --> 1
    • summary: Incorrect imagejpeg Syntax Breaks Image Transformation --> (ok 3.5.4) Incorrect imagejpeg Syntax Breaks Image Transf.
    • status: open --> open-fixed
     
  • Marc Delisle
    Marc Delisle
    2012-11-16

    • status: open-fixed --> closed-fixed
     
  • Michal Čihař
    Michal Čihař
    2013-06-11

    • Status: closed-fixed --> fixed