#3486 (ok 3.4.9) Firefox favicon frameset regression
I updated from 3.2.0.1 to 3.4.x (whatever is the latest a couple days ago, I think 2.4.0). The software is now pulling the localhost/favicon instead of the favicon defined by the link element. Showing individual frames works fine however phpMyAdmin works better with frames for me. I used WinMerge to see if there was any difference between 3.2 and 3.4 and there wasn't. I'm not sure how this regressed. There is a known Firefox bug that I don't think was ever resolved (https://bugzilla.mozilla.org/show_bug.cgi?id=261912). unfortunately I have never encountered this before and I don't see any straight forward answer to resolving this regression. I also tried retaining the original icon just to be sure. I'm not sure else what I could try other then continuing to use version 3.2.
This bug is important to me as I quickly identify tabs based off of their favicon. I highly prefer phpMyAdmin's favicon over my own so I can quickly locate the tab where the software is open as I use it frequently. I now have to use the older 3.2.x version in order to maintain my normal work environment.
This regression occurred in commit e20e693316852f0e8efb728b512c766d0ca4be52
In this commit, the hash setting functionality was fixed. I've tracked down the culprit to the below line of code in function setURLHash(hash) from update-location.js
window.location.hash = "PMAURL:" + hash;
Commenting it out fixes the favicon issue, but I'm guessing that it'll also break bookmarking.
Not sure how to proceed from here...
This bug was fixed in repository and will be part of a future release; thanks for reporting.