Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#581 Portal/Welcome configuration bug fixes

mySQL Version
closed-accepted
Gerry Kroll
5
2011-03-23
2011-03-18
ggpauly
No

This patch enables correct configuration of Portal/Welcome pages when multiple blocks of the same type are in use.

With this patch, such blocks can be moved up or down without losing their content.

Discussion

  • ggpauly
    ggpauly
    2011-03-18

    Sourceforge's upload is broken.

    Please contact me for diffs and patch files.

     
  • ggpauly
    ggpauly
    2011-03-19

    Managed to upload the patch and diff files.

     
  • ggpauly
    ggpauly
    2011-03-20

    This fixes bug 3208343.

     
  • Gerry Kroll
    Gerry Kroll
    2011-03-22

    George:
    The patch fixes the "lost everything" problem when the blocks are shifted around in the same column (main / right).

    However, if a block is shifted between columns (main /right), the JavaScript updates the block list correctly, but when the changed page configuration is saved ("Click here to continue"), the shifted block does not appear in the new column, It is, however, deleted from the original column.

    Example: The right column contains the Random Media block. When editing the Welcome or the Portal page, I highlight "Random Media" in the right list and then click the double arrow icon. The Random Media entry correctly moves to the bottom of the left list. I next click the "Click here to continue" button. The page refreshes but there's no Random Media block. When I next edit the Welcome or Portal page (the one I previously edited to move the Random Media block), that block does not appear in the list.

    This functionality works in the original code, but there's a problem: At least the "start slide show on page load" option is reset to default. I think this isn't what was intended. I think the entire block configuration should move with the block.

     
  • Gerry Kroll
    Gerry Kroll
    2011-03-22

    George:
    A note about packaging the patch:

    Don't bother with the DIFF files. Package the "real" scripts in a single ZIP file with the "authentication.php" file in an "includes" directory within the ZIP file. This ensures that the two patch files are applied as a unit and that they are delivered into the correct directory structure.

    With packaging like this, the user simply downloads the patch, unzips it, and copies the result to the server directory where PGV is installed without needing to worry about correct placement of the "authentication.php" (or any other) file.

     
  • ggpauly
    ggpauly
    2011-03-23

    Updated patch file (portalconfig.zip) has been uploaded. In addition to the regression noted by Canajun2eh, several other bugs have been fixed with this updated patch:

    "Moved" blocks now retain their configurations
    Block configuration now autocloses and updates parent page
    Help text is at bottom of configuration window so that buttons are stationary

     
  • Gerry Kroll
    Gerry Kroll
    2011-03-23

    • assigned_to: nobody --> canajun2eh
    • status: open --> closed-accepted