#569 Added notes/media/resn at wrong level

open
nobody
5
2010-06-07
2010-06-07
Andrew Gregory
No

When editing a source, or editing a family (and possibly elsewhere too), added notes, shared notes, multimedia objects, and restrictions are added at the wrong level. This can result in unwanted facts being created with the added note.

See SVN6906 edit_interface.php lines 1154-1158 and 2660-2664. The calls to print_add_layer do not specify a level. It should be 1, but the function defaults to 2. That results in an unwanted level 1 record being created to hold the incorrect level 2 record.

IMO, the print_add_layer function (in includes/functions/functions_edit.php) should not have a default for the level and that all calls to this function should be reviewed and an explicit level set for each call. If uncertain, it can be set to 2 as per the current default. AFAICT, files that refer to print_add_layer are:

edit_interface.php
includes/functions/functions_edit.php
includes/functions/functions_mediadb.php
modules/research_assistant/ra_functions.php

Discussion

  • ggpauly
    ggpauly
    2010-06-08

    This seems to be a bug report.

    Do you know if this is a trunk regression or was it present in release 4.2.3?

    Do you know if this is related to the shared note bugs reported by pduby?

     
  • Andrew Gregory
    Andrew Gregory
    2010-06-09

    Well, it's a bug, but I've described how I've fixed the problem on my PGV, so it's a sort-of patch...

    This problem is present in 4.2.3 (and the trunk, of course).

    If you're referring to bugs 3005849 and 3006124 (which seem to be reporting the same thing), then this is not related. I have, however, commented on 3006124 because I noticed that bug while looking for this one!