#567 reposition install.php buttons

open
nobody
5
2010-05-27
2010-05-27
ggpauly
No

Frequently the next/prev buttons on the install utility are overlaid an hidden by the data entry widgets. This may be due to the theme, fonts, browser, and sometimes just seems to happen.

Here is the diff:

424a425
> <div id="configdiv" style="position:relative;" >
476c477
< <div style="float: right;">
---
> <div style="position:absolute; top:-32px; right:20px" >
486c487
< <div style="float: left;">
---
> <div style="position:absolute; top:-32px; left:20px" >
490a492
> </div>

There is a workaround for this, pressing the enter key activates the next button. This may not be obvious to some users (me included).

Patch is based on build 6964 downloaded 24 May 2010. The patched file does not work with 4.2.3, although it should be easy to backpatch that version.

Patch tested in Firefox 3.0.19, Opera, and IE 6.0

Note: successful installation of both the patched and unpatched build 6964 required changing folder and file permissions and renaming config.dist to config.php. Is this a regression?

Patched file attached.

I had started on a more ambitious refactoring of install.php, but got tangled up.

Install.php would benefit from some major revision. Shouldn't language selection come first and be immediately effective?

Some of the items are misplaced on the config tabs, but more broadly this procedure should be as short as possible, with most items not required for basic functioning of the software (this includes almost all) have sensible or conservative defaults and be settable elsewhere (like the user setup, gedcom setup are already). For example, putting mail setup in a separate utility would simplify installation. The UI only renders correctly under limited circumstances - this patch only makes it usable, not pretty. It is difficult to edit this utility, given the fragility of the UI.

Discussion

  • ggpauly
    ggpauly
    2010-05-27

    Button placement patch for install.php

     
    Attachments