Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#561 Lightbox mouseover behavior

closed-accepted
Brian Holland
5
2010-04-28
2010-04-11
Andrew Gregory
No

I was investigating a problem with lightbox popping up PDF files on mouseover, as opposed to clicking as required by images. I found the problem in modules/lightbox/js/clsource_music.js line 837. I then found it had been fixed in SVN 6703, however, the fix is IMO inadequate.

The problem is parsing comma-separated arguments and handling extra whitespace around the comma. The SVN 6703 "fix" changes split(",") to split(", "), but that is not a robust solution. The fix should be split(/\s*,\s*/) so that any amount of whitespace is handled.

Similar changes should be made elsewhere too, eg line 830, 859, 880, and 973.

Discussion

  • Brian Holland
    Brian Holland
    2010-04-12

    Andrew,
    Well spotted, good solution, I'll get this implemented.
    Brian

     
  • Brian Holland
    Brian Holland
    2010-04-12

    File added to Subversion

     
  • Brian Holland
    Brian Holland
    2010-04-12

    applied in svn 6598

     
  • Brian Holland
    Brian Holland
    2010-04-12

    • assigned_to: nobody --> windmillway
    • status: open --> pending-accepted
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending-accepted --> closed-accepted