Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#482 add missing COMMIT_COMMAND global declarations

closed-accepted
Gerry Kroll
5
2008-07-22
2008-07-04
steve
No

The ability to track changes to a gedcom file in SVN or CVS was added with patch [1378524], but no longer works (see bug [1550804]).

One of the reasons for this is that the global $COMMIT_COMMAND is referenced in some functions where it is not declared as a global. This patch adds the global $COMMIT_COMMAND declarations.

This patch was generated from trunk/phpGedView, r3462. This is my first ever patch submission, so any feedback or patch-tiquite tips are appreciated.

Thanks,
Steve Hulet

Discussion

  • steve
    steve
    2008-07-04

    Patch to add add missing COMMIT_COMMAND global declarations

     
  • Gerry Kroll
    Gerry Kroll
    2008-07-07

    • assigned_to: nobody --> canajun2eh
    • status: open --> pending-accepted
     
  • Gerry Kroll
    Gerry Kroll
    2008-07-07

    Logged In: YES
    user_id=1198414
    Originator: NO

    Thank you.

    These patches (or something like them) have been applied. SVN 3494.

     
    • status: pending-accepted --> closed-accepted
     
  • Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).