Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#254 Fix non-working "Sources" tab in individual.php

closed-wont-fix
Gerry Kroll
None
5
2005-03-24
2005-02-02
Gerry Kroll
No

Ref: bug # 1114401

Module individual.php incorrectly looks for SOUR items
as level 1. They are, in fact, recorded at level 2 and
are embedded in level 1 records.

The fix consists of removing all mention of SOUR within
the 3 instances of the code that looks for level 1
OBJE, NOTE, and SEX facts, and adding a new pattern
match for "/2\sSOUR\s@.+@/". When found, the entire
record containing the level 2 SOUR reference is copied
according to the original code.

When generating the contents of Tab 3 (Sources), the
pattern to look for is changed as shown above.

A revised individual.php module (base code level: 3.2.2
final) is attached as individual.zip

Discussion

  • Gerry Kroll
    Gerry Kroll
    2005-02-02

     
    Attachments
  • Gerry Kroll
    Gerry Kroll
    2005-03-24

    • status: open --> open-wont-fix
     
  • Gerry Kroll
    Gerry Kroll
    2005-03-24

    • assigned_to: nobody --> canajun2eh
     
  • Gerry Kroll
    Gerry Kroll
    2005-03-24

    Logged In: YES
    user_id=1198414

    Please close this.

    The Sources tab works the way it's supposed to. It's only
    supposed to display sources that aren't attached to specific
    Facts.

    I'll submit an RFE to change this. After discussion, I'll
    re-work the logic as required.

     
  • Patrik Hansson
    Patrik Hansson
    2005-03-24

    Logged In: YES
    user_id=918839

    I close this as John probably is Busy

     
  • Patrik Hansson
    Patrik Hansson
    2005-03-24

    • status: open-wont-fix --> closed-wont-fix