Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

label generation in print_fact

2010-01-26
2013-05-30
  • Robert Shaw
    Robert Shaw
    2010-01-26

    I've been looking over function print_fact, and wonder at the handling of the fact labels as they are sent out in the HTML.  It looks like they are generated in three places, with three different algorithms in functions_print_facts.php:

       * line 160: $factarray[$fact] is used
       * lines 215-221: $pgv_lang[$factref] is used if nonnull, else $factarray[$factref] if nonnull, else $factref
       * lines 458-453: $factarray[$factref] is used if nonnull, else $factref
    

    The contexts are a bit different (generic, object/event, sub-ADDRs), but it's not clear to me why that should cause the different treatments.  Can anybody offer an explanation for the different handling?

    (Aside: there seems to be useless code preceeding 160 which calcs $label much like 215-221, but then it isn't used.)

     
  • Gerry Kroll
    Gerry Kroll
    2010-01-26

    The logic at lines 458-459 is correct and should be used in the other two locations you cite.

    I'll correct this in SVN.

     
  • Gerry Kroll
    Gerry Kroll
    2010-01-26

    Actually, lines 215 to 221 are correct.