#2780 Site Map missing the $SERVER_URLvar?

v4.3.0
closed-fixed
Greg Roach
None
5
2010-02-09
2010-02-08
Marc Riley
No

After upgrading to Phpgedview 4.3.0 I updated my site map on Google and it told me it was a bad site map. After looking into it, I noticed the $SERVER_URL being handed to the site map mod was blank? So I used vi and added the missing WWW to $SERVER_URL. Well that broke the entire site... so for a workaround I added some code in the modules\sitemap\index.php to get the current location of the site and use that for the site map. WORKED Great!

So real question is what happened to the config.php var $SERVER_URL? Is it suppose to be blank now?

to fix the site map mod i added the following code to ~line 46 and renamed the rest of the $SERVER_URL vars to $server in the site map mod.

if (!$SERVER_URL) {
$server = "http://" . $_SERVER['SERVER_NAME'] . "/";
} else {
$server == $SERVER_URL;
}

Discussion

  • Greg Roach
    Greg Roach
    2010-02-08

    A new set of constants was recently introduced to handle the requested URL. The change wasn't propogated to the sitemap module.

     
  • Greg Roach
    Greg Roach
    2010-02-08

    • assigned_to: nobody --> fisharebest
    • status: open --> pending-fixed
     
  • Greg Roach
    Greg Roach
    2010-02-08

    This problem has been fixed in SVN.

    Please can you check that the fix works for you.

    If you agree that the problem is fixed, you should change the bug status to "Closed".

    If you think the problem is not fixed, please provide further information.

    Regards,

    The PGV Team

     
  • Marc Riley
    Marc Riley
    2010-02-09

    • status: pending-fixed --> closed-fixed
     
  • Marc Riley
    Marc Riley
    2010-02-09

    Works great.. thanks