#1915 Statistics Block One Hebrew Year

v4.1.3
open-fixed
Greg Roach
None
5
2008-11-17
2008-02-25
Meliza Amity
No

I see the latest birth year as 5768.
All the other statistics values are in Gregorian years.

1 BIRT
2 DATE 22 JAN 2008
1 BIRT
2 DATE @#DHEBREW@ 15 SHV 5768

Discussion

  • Greg Roach
    Greg Roach
    2008-02-25

    Logged In: YES
    user_id=1466942
    Originator: NO

    These two dates are the same (i.e. they have the same julian day).

    We simply find the date with the highest JD, and then print the year for that date.

    If there is more than one date with the same JD, one will be picked at random.

     
  • Greg Roach
    Greg Roach
    2008-02-25

    Logged In: YES
    user_id=1466942
    Originator: NO

    ...continued (clicked submit too soon).

    I can add the calendar type to the sort key, so that it always prefers one to the other.

    If you want this logic adding, can you let me know which calendar should take priority, and whether you want the same logic on first-year as well as last-year.

     
  • Meliza Amity
    Meliza Amity
    2008-02-26

    Logged In: YES
    user_id=959928
    Originator: YES

    I would prefer on my site the Gregorian dates both for the earliest and the latest dates, others might prefer other calendars as the primary ones.

    Meliza

     
  • Greg Roach
    Greg Roach
    2008-02-27

    Logged In: YES
    user_id=1466942
    Originator: NO

    SVN2626. Where equal dates exist, gregorian dates are given priority.

     
  • Greg Roach
    Greg Roach
    2008-02-27

    • assigned_to: nobody --> fisharebest
    • status: open --> pending-fixed
     
  • Meliza Amity
    Meliza Amity
    2008-02-28

    Logged In: YES
    user_id=959928
    Originator: YES

    I see still 5768 for the Latest Birth Year even after I clean the cache.
    SVN revision: 2640

     
  • Meliza Amity
    Meliza Amity
    2008-02-28

    • status: pending-fixed --> open-fixed
     
  • Greg Roach
    Greg Roach
    2008-04-24

    Logged In: YES
    user_id=1466942
    Originator: NO

    The statistics class has been rewritten (without this logic).

    I've added it back in.

    SVN2909

     
  • Greg Roach
    Greg Roach
    2008-04-24

    • status: open-fixed --> pending-fixed
     
  • Meliza Amity
    Meliza Amity
    2008-04-24

    Logged In: YES
    user_id=959928
    Originator: YES

    We see still the Hebrew birth year on the statistics block, when the child was born between sunset and midnight.
    For instance when the Gregorian date is "20 FEB 2008" and the Hebrew date is "@#DHEBREW@ 15 ADR 5768".
    We should check for equal dates or equal+1 day in the Hebrew date.

    By the way, if the Hebrew date is written in the GEDCOM before the Gregorian date, we see only the Hebrew date in charts, the Close relatives Tab and on the family page.

    Meliza

     
  • Meliza Amity
    Meliza Amity
    2008-04-24

    • status: pending-fixed --> open-fixed
     
  • Greg Roach
    Greg Roach
    2008-11-17

    • milestone: --> v4.1.3