#1038 Research Assistant Problems

v3.3.8
closed-fixed
John Finlay
None
5
2014-07-07
2006-07-19
Meliza Amity
No

I sent the attached to John on July 3, 2006.
It does not seem that problems were solved till now.

Several text variables are already defined in the PGV
language files.
Having the same labels defined also in the research
assistant language files, causes PGV to show this
variable. I have commented out any duplicate labels
that I have detected.
This might explain why I see some texts in Hebrew on
the pages.

Search is already defined.
Commented it out.
$_SESSION['pgv_lang["search"]'] = "Search";
And then I returned it back, because it was required.
I hope this value will not be used on other PGV pages.

$pgv_lang["edit_folder"] is defined twice (different
texts).

I have added a Hebrew language file on my site, but
most text variables are still shown in English.
It seems that only the English Research Assistant
language file is showm.

I changed the name of my Hebrew file to en.
Now I see most Hebrew texts.

There seem to be pretty many texts still to translate.
Where are they used?
How do I reach these pages?
For instance a Reaserch Log page?

Individual Page

1. Auto Search on RtL page
The selection values and boxes are left-justified,
should be right-justified.

2. Include surnames/include given names/include birth
year/include death year seem to be hard-coded in
ra_functions.php lines 1204-1210.

3. We should not show future death years.

4. I do not know where the "folder" text is taken
from". Does it come from the cache or is it, too
hard-coded?

5. Tasks Help speaks of VIEW.
I see no VIEW?

6. Missing Information Help text is concatenated
together without a space between the sentences and the
tutorial link does not work.

Research Assistant Page

1. PrintReady should be added to the text fields of
folders and tasks, also results.

2. View Probabilities – Data Correlation

2.A The top text and the title and column headers are
hard-coded in forms/ra_ViewInterfaces.php.

So is probably the text "Recalculate"

What else is still hard-coded?

2.B In Hebrew one writes "place death", "place birth" …
"source birth" … "date education" …
Now the words are in wrong sequence.

2.C I would like to add a Place to the SSN, as the
social security death index data-base has this
information, but PGV does not show this field on the
editing screens.

2.D Should we really fill a place (and a source) for
instance for the address, telephone and email?
We do not have the Place on the editing screens.

2.E Ashkenazi Jews do not give a name that a live
relative has.
So, some of the current statistics are not of interest.
How can admins remove them from their site?

2.F Comparing the child's name to a grandparent's name
might perhaps be of interest.

2.G The following texts are nor clear to me:
Family as a Child Wife Family as a Child Wife
Family as a Child Husband Family as a Child Husband

3. View Folders
3.A The page shows nothing when no Folders are defined
yet. Should we see the titles?

3.B Page help is not yet available??

4. Auto generate tasks
All the texts are in English.
I do not see them in the ra language file.
They are probably hard-coded.

5. Add New Task
5.A I see the title, Assign Task and Description in
English.

5.B I would include a box where it is possible to fill
the Source and/or Indi ID, if they are known, instead
of having to search for them.

6. Add New Folder / Edit Folder
I see the button texts "Reset" and "Delete" in English.
Odd.
The button text "Add" (etc.) is shown in Hebrew from
the regular PGV language files.

7. Edit Task
7.A Texts
Up Folder is shown in English although I translated
$pgv_lang["up_folder"].

"Complete" is shown in English

Add comment pop-up "close window" is in English.

7.B I do not see the Result that I filled when I closed
a task.

7.C I do not see any help.

7.D I get now when I look at the data that I prepared
earlier:
Fatal error: Call to a member function on a non-object
in
/home/meliza/public_html/future/phpGedView/modules/research_assistant/forms/ra_EditTask.php
on line 341

8. Complete the Task
Texts are shown in English.
I do not find them in the language file

9. Task View
Help states that we should see the Description and the
Details.
They are not on the page?

10. Research Assistant Tutorial, User Tutorial etc. on
Help pages
I click on the links and get error 404

Discussion

1 2 > >> (Page 1 of 2)
  • Meliza Amity
    Meliza Amity
    2006-07-29

    Logged In: YES
    user_id=959928

    I changed some code in the menu.php and added files
    lang.en.php, lang.he.php and lang.fi.php.
    global $LANGUAGE, $pgv_language;
    require( $pgv_language["english"]);
    if (file_exists( $pgv_language[$LANGUAGE])) require
    $pgv_language[$LANGUAGE];
    if
    (!file_exists('modules/research_assistant/languages/lang.en.php'))
    return null;
    require_once
    'modules/research_assistant/languages/lang.en.php';
    if
    (file_exists("modules/research_assistant/".$pgv_language[$LANGUAGE]))
    require_once("modules/research_assistant/".$pgv_language[$LANGUAGE]);

    I cannot remove the old ra_lang.xx.php files because then if
    I also update the line 42 in ra_functions.php, I get errors.
    Where is the array $pgv_lang filled? Have now each language
    file twice till this is corrected.

    Research Assistant Page

    1. PrintReady should be added to the text fields of
    folders and tasks, also results.
    I have added PrintReady to several files and lines

    5. Add New Task
    The description is shown correctly.

    7.D seems now OK

    New:
    11. View Task form
    * The Title is printed always left-justified even on Hebrew
    page for a Hebrew title
    * The Description is adjusted according to the page language.
    * This does not look good
    * I do not know how to correct this in ra_ViewTask.php

    12. The shown Source List prints only the TITLes, not the
    _HEB etc. title texts.

    13. Task view Help text of Task Name is odd.

     
  • Meliza Amity
    Meliza Amity
    2006-08-14

    Logged In: YES
    user_id=959928

    The census etc. search should work for married women also on
    their married names.

     
  • Meliza Amity
    Meliza Amity
    2006-09-25

    Logged In: YES
    user_id=959928

    too many variables show still in English on the Hebrew page.

     
  • Meliza Amity
    Meliza Amity
    2006-09-25

    Logged In: YES
    user_id=959928

    too many variables show still in English on the Hebrew page.

     
  • Meliza Amity
    Meliza Amity
    2006-10-06

    Logged In: YES
    user_id=959928

    I see on the Source.php pages the text
    No tasks associated with this individual.

     
  • John Finlay
    John Finlay
    2007-03-07

    Logged In: YES
    user_id=300048
    Originator: NO

    These have all been fixed:
    2.C. The place referred to in the SS death index is the place of their death. So I still wouldn't add a place to the SSN field.

    2.D. Is this related to the RA?

    2.E. There is a file in the research_assistant folder which has the rules that should be used when calculating inferences. However the rules are used to calculate what is in your database and it then uses those rules to help suggest possible values for missing information. So if in your database such information is never used, then the probability values for them would be 0. So it should not affect your data. That is the whole purpose of calculating the rules and probabilities so that we can give you suggestions that are the most appropriate for your dataset.

    5.B. The box has been purposely left out to allow for the selection of multiple people. For admins and testers it is perhaps inconvenient, but I think more usable to the average user. I have plans for a future release which will make it even easier to add people to different forms and charts throughout pgv.

    --John

     
  • John Finlay
    John Finlay
    2007-03-07

    • assigned_to: nobody --> yalnifj
    • status: open --> closed-fixed
     
  • Meliza Amity
    Meliza Amity
    2007-03-08

    Logged In: YES
    user_id=959928
    Originator: YES

    2.C. The Social Security Death Index includes the state where the SSN was issued in addition to the death state and last address.

    2.D. The PhpGedView editing form does not include a Place field for addresses, phones, faxes ...
    The Gedcom Standards do not define a Place for the address structure records.
    I think PGV should be consistent in its different functions.

    Meliza

     
  • Meliza Amity
    Meliza Amity
    2007-03-08

    • status: closed-fixed --> open-fixed
     
  • Greg Roach
    Greg Roach
    2008-11-17

    • milestone: --> v3.3.8
     
1 2 > >> (Page 1 of 2)