#7 Fix E_NOTICE suppression.

closed
nobody
None
5
2006-01-23
2005-12-21
Anonymous
No

file reader.php is incorrectly setting the error
reporting level using ^ E_NOTICE, which toggles the
value of E_NOTICE should probably be using & ~E_NOTICE.

163c163
< error_reporting($errlevel ^ E_NOTICE);
---
> error_reporting($errlevel & ~E_NOTICE);

Discussion

    • status: open --> closed
     
  • Logged In: NO

    The code is taking the previous error level and flipping the
    E_NOTICE bit with the exclusive or operator.
    Therefore if E_NOTICE is currently set it will be unset. If
    E_NOTICE is currently unset it will be set.
    This behaviour is almost certainly not desired.