#72 Miscellaneous

1.06
closed-fixed
Robert May
1
2008-02-13
2007-06-11
Peter Naimoli
No

#1: In the 'AddMasked' subroutine in GUI.pm, the final statement on line 2399 reads:

return $self->AddBitmapMasked($bitmap);

it should read:

return $self->AddBitmapMasked($bitmap, $colorMask);

#2: In the 'new' subroutine in the package Win32::GUI::Textfield (around line 1406), perl will produce a warning when one tries to use the non-array -prompt option. The reason is because the scalar $left is never initialized when $options{-prompt}) is not an ARRAY. In this case added the line

$left = $options{-left};

above $text = $options{-prompt}; at line 135. Also, $width is not initialized in this case. I set it to 0 in the very beginning.

Discussion

  • Peter Naimoli
    Peter Naimoli
    2007-06-11

    • priority: 5 --> 3
     
  • Robert May
    Robert May
    2007-07-15

    Logged In: YES
    user_id=674651
    Originator: NO

    Thanks for the report. For #1 I have integrated your change. For #2 I think more thought is needed - the whole code dealing with the -prompt option is not good; whilst your suggestions silence the warnings I don't believe that setting the left position of the label and the textfield to the same thing is the right thing to do. I'm going to re-write the whole function, but need to decide what the 'correct' behaviour of the non-ARRAY prompt option should be.

     
  • Robert May
    Robert May
    2007-07-15

    • assigned_to: nobody --> robertemay
     
  • Robert May
    Robert May
    2007-07-22

    Logged In: YES
    user_id=674651
    Originator: NO

    OK, whole code for Win32::GUI::Textfield::new() has ben re-written and committed to CVS. New code will be in the next Win32::GUI release. Regards, Rob.

     
  • Robert May
    Robert May
    2007-07-22

    • priority: 3 --> 1
     
  • Robert May
    Robert May
    2008-01-31

    • labels: --> Win32::GUI Core
     
  • Robert May
    Robert May
    2008-01-31

    • milestone: --> 1.06
     
  • Robert May
    Robert May
    2008-01-31

    • status: open --> open-fixed
     
  • Robert May
    Robert May
    2008-02-13

    • status: open-fixed --> closed-fixed