Hi Maynard,

The fix is in the CVS.

Milena Milenkovic


From: maynardj@linux.vnet.ibm.com
To: perfinsp-list@lists.sourceforge.net, Milena Milenkovic/Austin/IBM@IBMUS
Date: 06/11/2010 11:49 AM
Subject: [PATCH] Fix stapitrace compile error





Hi, Milena,
Thanks for committing the previous three patches I posted.  Unfortunately, there's one little thing I missed when I forward ported those changes to the current code base.  In preparation for updating the stapitrace package to push into Fedora EPEL (for RHEL 6), I took those 3 patches and manually added them into the stapitrace's Dpiperf code base.  The resultant stapitrace tool got the following compile error when trying to build the SystemTap-based kernel module:

                /tmp/stapVqBbI4/stap_11155.c: In function ?SoftTraceOn?:
                /tmp/stapVqBbI4/stap_11155.c:640: error: ?addr? is used uninitialized in this function

In my patch where I moved around the #ifndef STAP_ITRACE tags, I missed the fact that the initialization of addr.cval on line 348 would not happen for my stapitrace module.  The attached patch simply moves that initialization up next to the declaration of 'addr', where we're still inside a #ifndef STAP_ITRACE tag.

Thanks.
-Maynard

[attachment "pi-stapitrace-build.patch" deleted by Milena Milenkovic/Austin/IBM]