#321 Fix setting http_proxy in WGET_OPTS

PeerGuardian_Linux
closed
jre-phoenix
pglcmd (1)
5
2012-11-11
2012-10-29
hemisfear
No

The instructions for setting an http_proxy in WGET_OPTS in incorrect in pglcmd.defaults.in. If you don't prepend with `env`, the `http_proxy=URL` will be interpreted as an executable to execute.

Replace:

# WGET_OPTS="http_proxy=URL wget -q -t 5 -T 120 -w 5 --user-agent=${CMD_NAME}/${VERSION}"

With:

# WGET_OPTS="env http_proxy=URL wget -q -t 5 -T 120 -w 5 --user-agent=${CMD_NAME}/${VERSION}"

Discussion

  • jre-phoenix
    jre-phoenix
    2012-10-29

    Thanks! I committed your change.

    However I don't fully understand its necessity. What exactly do you mean with "If you don't prepend with `env`, the `http_proxy=URL` will be interpreted as an executable to execute."? Did you get any error messages?

     
  • hemisfear
    hemisfear
    2012-10-29

    This the the error message before the fix:

    Updating blocklists ...
    /usr/bin/pglcmd: 799: /usr/bin/pglcmd: http_proxy=http://localhost:9999: not found
    * Error 171: No connection to http://www.iblocklist.com/lists.xml. Aborting!

     
  • jre-phoenix
    jre-phoenix
    2012-10-29

    Ok, thanks again.