#312 build system

PeerGuardian_Linux
closed
hasufell
None
3
2012-11-11
2012-01-17
hasufell
No

Pglinux has no real build-system, just a bunch of makefiles which need some heavy patching to work on different distros.
No configure script and even uninstall-rules are missing.

If you fix that, it would make life easier for people not using distros with pre-compiled binaries.

Discussion

  • jre-phoenix
    jre-phoenix
    2012-01-19

    Thanks, basically true.
    Although you should only edit the main pgl/Makefile (NOT those in the subfolders!).
    Further "heavy patching" should only be correcting some path settings, which differ across the distributions.

    If you can show me a good piece of Linux software that you would recommend, I can have a look at it and try to improve pgl.
    Also, if you tell me the concrete problems I might try to solve them.

    all kind of contributions (reports, patches, complete rewirtes,...) are all welcome.

     
  • jre-phoenix
    jre-phoenix
    2012-01-19

    Argh, you already posted a patch here: http://forums.gentoo.org/viewtopic.php?p=6932026#6932026

    Please, please, please, always fell free to share your patches with upstream, no need to restrict improvements to gentoo only.

    Thus having said, I can't promise when I integrate your things (real life time constraints), but I will!

     
  • hasufell
    hasufell
    2012-03-27

    Please contact me, I have rewritten the whole build-system for use with autotools.

     
  • jre-phoenix
    jre-phoenix
    2012-03-27

    Great, thanks! I'm really excited to see your work.
    I just added you to the "peerguardian" project with write access to the git repository. If you can build pgl with your changes, then please just commit them to the git repository. In case I have objections to your code, I can easily revert any changes - so don't worry about breaking anything.

    Are you familiar with git? If you need help, just contact me.

    Best practice for git commits:
    - Make commits containing only one topic (logical change). Please avoid to mix any topics into one commit, especially avoid to commit whitespace changings. That would make a review unnecessary difficult. I recommend to use gitk and especially git-gui for making the commits.
    - Explain what you commited. The first line of the commit message has to be a short (up to 60 characters) "headline". 2nd line is always empty. Beginning with the 3rd line you can give details.

    BTW, I tried to answer your mail, but got an "550 550 unknown user (state 17)".