#36 rfits and type A and X data

closed-accepted
nobody
None
5
2004-02-12
2004-01-22
Kaj Wiik
No

rfits has problems reading data records consisting of
character strings (rA) and bit arrays (rX). In bit
arrays the bits are encoded into integral number of
bytes with trailing bits zero, not as one byte per bit.

In the character array reading routine the replacement
substr(..,..,..,'') was missing.

What is a bit alarming, I did not understand the
meaning of the line 588 in FITS.pm (if(ref $szptr eq
'SCALAR') ....), because the variable pointed by $szptr
will always change from scalar into PDL during the
processing.. Anyway, taking that out made the byte
count correct.

Patch is included..

Cheers,
Kaj
kaj.wiik@iki.fi

Discussion

  • Kaj Wiik
    Kaj Wiik
    2004-01-22

     
    Attachments
  • Craig DeForest
    Craig DeForest
    2004-02-12

    Logged In: YES
    user_id=20200

    Applied to CVS. Thanks for the patch and your patience!

     
  • Craig DeForest
    Craig DeForest
    2004-02-12

    • status: open --> closed
     
  • Craig DeForest
    Craig DeForest
    2004-02-12

    • status: closed --> closed-accepted