#69 Make rcols and new_pdl_from_string use the same parser

open
David Mertens
None
1
2013-01-02
2012-02-07
David Mertens
No

I wrote a new parser for new_pd_from_string, and didn't think to consult the code from rcols. Would it be fruitful to use the same number-to-string parser for the two?

Discussion

  • Chris Marshall
    Chris Marshall
    2012-02-13

    rcols() uses perl's built-in conversion of number strings
    to numbers to produce the values for the pdl()
    constructor. The hex conversion would be done
    in front of the conversion to pdl. I plan to use
    POSIX::strtol() to enhance rcols() to support hex
    and octal input fields. That might be appropriate
    to use in new_pdl_from_string() for the same
    purpose.

     
  • Chris Marshall
    Chris Marshall
    2013-01-02

    Reducing the priority since this is pretty much an internal-only modification that does not appear to arise from a specific use case. I'm marking it Pending since I believe that it may have been overtaken by ongoing PDL development. @David: please Open/Close/Comment as desired.

     
  • Chris Marshall
    Chris Marshall
    2013-01-02

    • priority: 5 --> 1
    • assigned_to: nobody --> run4flat