It would be handy, if pcmanfm would show image dimensions in status bar, when you select it.
Probably, make it as option, so it can be disabled for perfomance.
Well, strictly said, it is not "Fixed". It is not implemented in PCManFM because it is not lightweight solution but implemented in your plugin, which you can use.
BTW, you've got a memory leak in your code - data returned by fm_path_display_name() should be freed after usage. And also that function returns string not appropriate to use for anything but display, and to get a path string the fm_path_to_str() should be used instead.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Maybe this points should be better documented.
You can place link to fm_path_to_str from fm_path_display_name description and add note about need of freeing memory after both of them with g_free.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You are wrong. From description for fm_path_display_name() in HTML docs:
Returns : path string. [transfer full]
The [transfer full] means exactly - string is allocated and should be freed aftwards. :)
And thanks, I'll revise that file for more clear documentation.
Thank you very much.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, strictly said, it is not "Fixed". It is not implemented in PCManFM because it is not lightweight solution but implemented in your plugin, which you can use.
BTW, you've got a memory leak in your code - data returned by fm_path_display_name() should be freed after usage. And also that function returns string not appropriate to use for anything but display, and to get a path string the fm_path_to_str() should be used instead.
Thank you. Fixed this too.
Maybe this points should be better documented.
You can place link to fm_path_to_str from fm_path_display_name description and add note about need of freeing memory after both of them with g_free.
You are wrong. From description for fm_path_display_name() in HTML docs:
Returns : path string. [transfer full]
The [transfer full] means exactly - string is allocated and should be freed aftwards. :)
And thanks, I'll revise that file for more clear documentation.
Thank you very much.