Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#267 Display image dimensions in status bar

closed-wont-fix
5
2014-01-06
2012-10-08
Alexander Varnin
No

It would be handy, if pcmanfm would show image dimensions in status bar, when you select it.
Probably, make it as option, so it can be disabled for perfomance.

Discussion

<< < 1 2 3 4 > >> (Page 3 of 4)
  • Thank you very much.
    I was wrong in finalize sequence. Fix committed.

     
  • Ok. Thank you.
    I have committed update to github repo.
    I think we can assume this request as closed for 1.2.0 release.

     
  • I've added installing pcmanfm-modules.h into /usr/include (or whatever you chose on configure) so now you should not include it into your sources anymore.
    Thank you very much. I'll create a modules page on the wiki.lxde.org and mention your module there for those who would like to have it.

     
  • I would suggest you never use strcpy or sprintf but use safe versions such as snprintf instead.
    Thank you. :)

     
  • Ok, I'll fix it :) Thanks.

     
    • status: open-later --> closed-fixed
     
    • status: closed-fixed --> closed-wont-fix
     
  • Well, strictly said, it is not "Fixed". It is not implemented in PCManFM because it is not lightweight solution but implemented in your plugin, which you can use.

    BTW, you've got a memory leak in your code - data returned by fm_path_display_name() should be freed after usage. And also that function returns string not appropriate to use for anything but display, and to get a path string the fm_path_to_str() should be used instead.

     
  • Thank you. Fixed this too.

    Maybe this points should be better documented.
    You can place link to fm_path_to_str from fm_path_display_name description and add note about need of freeing memory after both of them with g_free.

     
    • status: closed-wont-fix --> open-wont-fix
     
<< < 1 2 3 4 > >> (Page 3 of 4)