#867 terminal lilyterm isn't known

1.2
closed-fixed
libfm (248)
3
2014-05-11
2014-05-07
Jean Dumas
No

With PCManFM 1.2.0, when trying to setup a new terminal emulator I get the following warning:

(pcmanfm:19227): WARNING : terminal lilyterm isn't known, consider report it to LibFM developers

Why don't you allow the user to specify its own terminal? I mean, I understand that features such as "leave terminal window open after execution" (I don't see where this option is btw) wouldn't work because of different command line arguments. But there is like a thousands different terimal emulators out there, so at the very least the user should be able to specify its own cli arguments (that what the "advanced" option tab is there for right?).

Also, I tried to give the value x-terminal-emulator -d %s to the terminal option, but even with that lilyterm opens to the default home instead of the current directory.

Can you please think of a way to improve this mechanism without it becoming to mush of a pain in the ass?

Discussion

    • Priority: 5 --> 3
     
  • Thank you very much for reporting this.

    You are wrong in both statements of not allowing the user to specify a terminal, and in declaring it's a pain in the ass. The terminal support in PCManFM is designed to be as simple and smooth as possible. While some terminal is missed in list of known ones, that doesn't mean it's not supported and cannot be used. Not known terminals are considered ones that have only -e option to execute a command. If your terminal supports -e then you still can use it safely. That option is added automatically when needed so you should never specify it.

    And yes, you cannot use -d %s syntax because %s is meaningless in the terminal command line, it's why it doesn't work for you. If your concern is the working directory - all PCManFM functions should set working directory correctly for any terminal. Feel free to open a bug request with full description what's wrong if it doesn't do in some case.

    The option to leave terminal window open after execution is one of options to execute applications which use terminal. Applications are used to open files and in system menu and can be edited using 'Properties' on their icon.

     
  • Jean Dumas
    Jean Dumas
    2014-05-08

    Hi,

    Thank you for your answer. I think I may have been mislead by [#855], which made me think that the support for terminals in PCManFM was more complex than necessary.

    So, the thing is, when I use lilyterm as a terminal emulator, and press F4 in a custom directory, lilyterm is still started in my $HOME. Yet for other terminals that I've tried everything works as expected (lxterminal, xterm, urxvt to name a few). Do I need to file a separate bug report for that? I did assume that the current path is passed as an argument to the terminal to be opened (hence the need to use the -d %s syntax), but it seems this is not how it works.

    About your last §: ok, I see where the option is! But how is it handled for different terminals then? I can assume that if the terminal isn't known then the option would have no effect right?

     

    Related

    Bugs: #855

  • Well, if that issue happens only with lilyterm then let it be in this report, I'll try to find what's wrong with that terminal, it's really weird issue.

    You are right about no effect if terminal isn't known. That is one of reasons why LibFM keeps own terminal database, so it can handle that.

    Thank you.

     
  • I hope both issues are fixed in current GIT sources of LibFM and PCManFM, you have to update both to get it working with lilyterm. Check it when possible, please. Thank you very much.

     
    • status: open --> pending-fixed
    • assigned_to: Lonely Stranger
     
  • Jean Dumas
    Jean Dumas
    2014-05-09

    Hi,

    I would like to compile the GIT sources locally (so as not to mess up with my current system-wide install), but I'm not familiar with autotools. I manage to make && make install libfm on, say, $HOME/bla/libfm, but how do I tell pcmanfm to compile using $HOME/bla/libfm? The instructions on the wiki or in the INSTALL file aren't very clear on that. Can you please give a quick example on how to proceed?

     
    Last edit: Jean Dumas 2014-05-09
  • Well, I would suggest to really replace your system-wide install because there is nothing new in current code but few bug fixes so update your files is completely safe.
    Though use of local install is also possible, you should export PKG_CONFIG_PATH=$HOME/bla/libfm/lib/pkgconfig before running configure for pcmanfm then and use LD_LIBRARY_PATH=$HOME/bla/libfm/lib before running the pcmanfm itself.

    Thank you very much for noticing about Wiki, it's worth to be written there.

     
    Last edit: Lonely Stranger 2014-05-09
  • Jean Dumas
    Jean Dumas
    2014-05-11

    Hmm, it seems that I had to type make install-pkgconfigDATA when building libfm locally. Now it works and compile fine! So I can confirm that with this fix it now works for me (unsurprisingly).

    And about replacing my system-wide install, well it's just a matter of convenience for me: I prefer to limit the number of apps I install manually, for the sake of easier upgrades.

     
    • status: pending-fixed --> closed-fixed
     
  • Glad to hear it works now. Thank you. I close the ticket then. :)

    But it is a bit strange that you had to run make install-pkgconfigDATA, it should have been installed by make install run - latter one a is meta target which includes both recursive things and install-pkgconfigDATA, and make install-strip also runs make install but with few additional variables.