#861 [libfm] peristent rubberbanding when executing files (or any other dialog) - with fix

1.2
closed-fixed
libfm (248)
6
2014-05-09
2014-04-19
gregor_b
No

"
[...]

the latest version of libfm [pcmanfm 1.2 at the time, which is now used by Lubuntu 14.04] has the very annoying bug that if I click some executable file and pcmanfm asks how and if it should be executed it also starts drawing the rubberband (which is then visible after I close the dialog and can't be stopped until I click again onto the icon view.

[...]
"

https://github.com/lxde/libfm/pull/1/files

Seems like the guy who maintains the github mirror couldn't care less. I wonder how it could get past thorough pre-release testing if its already so annoyingly evident in everyday use.

Related

libfm: libfm

Discussion

    • labels: --> libfm
    • Priority: 5 --> 6
     
  • Thank you very much for reporting this. I should agree with you, too few people seemed to test it to notice this problem in time of pre-release.

    Your "fix" (removing code) may get rid of this issue but it reintroduces another annoying bug which was fixed by the code you remove: double-click starts drag&drop if you move mouse even a bit. So it needs another fix.

     
  • gregor_b
    gregor_b
    2014-04-19

    New version of the "fix" (adding code ;)). Calling stop_rubberbanding seems to work as well as not starting it, however I can't tell if it affects the prior bug because I can't reproduce it.

    (attachment removed)

     
    Last edit: gregor_b 2014-04-19
  • Sorry but start and stop rubberbanding have zero effect, i.e. as useful as do nothing, therefore reintroduces mentioned bug.

     
    • gregor_b
      gregor_b
      2014-04-19

      From looking at the code of exo_icon_view_{start|stop}_rubberbanding it is not really obvious that the net effect is zero, but I guess you kept in mind any side effect of any function there when commenting.

      Did you test if the original bug is reintroduced or is the answer by principle?

      In any case I would accept a bug which never occured to me in exchange for a bug which reliably happens every time I run an executable file, without much thinking.

       
  • Yes, I have tested it, it does.
    No problem, I will fix your issue when time permits.
    Thank you.

     
  • I believe this issue is fixed now in current GIT repository. Check it when possible, please, and reopen the report if something is still wrong. Thank you very much.

     
    • gregor_b
      gregor_b
      2014-05-09

      I can confirm the fix worked. Thank you, too.

       
    • status: open --> closed-fixed
    • assigned_to: Lonely Stranger