Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#640 Coming pre-selected with gksu.

1.2
closed-fixed
pcmanfm (108)
3
2013-12-25
2012-10-24
Sérgio Cipolla
No

The 'open as root' command is coming pre-selected with 'gksu' in current git libfm/pcmanfm.
This makes the action fail with an error instead of taking to the preferences.
http://www.zimagez.com/zimage/screenshot-10242012-061337am.php

Note: 'gksu' is Debian specific.

Discussion

  • We hope this issue is completely fixed in the Git repository recently.
    Check it out when it's possible for you and if the bug still exists then reopen the report, please.
    Thank you very much.

     
  • The 'gksu' isn't Debian specific, BTW. The same behavior should be now in both cases when no command is set or the command cannot be executed.

     
    • priority: 5 --> 3
    • assigned_to: nobody --> lstranger
    • status: open --> closed-fixed
     
  • Thank you for looking into this, but I still think it shouldn't come pre-defined with an app that's specific to a distribution (and its derivatives).

     
    • status: closed-fixed --> open-fixed
     
  • Seriously Andriy, you have your coding standards and don't want to make 'dirty' hacks but what about someone trying to open pcmanfm as root for the first time and instead of the traditional advice to configure that command, have an error saying 'Failed to execute child process "gksu" (no such file or directory)' in a distribution that isn't Debian based and has nothing to do with gksu?

     
  • My suggestion would be coming with an empty field and having the 'command not configured' dialogue, but if you think that it won't be too much overhead and you really think users should have the convenience of a pre-configured command, then maybe it could check for some executables (beesu, gksu, ktsuss and others I don't know of) and in case they're lacking then open the 'command not configured' dialogue.

     
  • About gksu: it is a GNOME application, even it is developed by some Debian people. But since it is already there for ages I believe it is very inappropriate to change this, especially so close to release, because some people will expect former behavior.
    And about your example: there will be an error message if no command is set anyway, just text of the message will be another. After that error message there will be a preferences window opened to edit su_cmd. And if wrong command was set then user will get the same message anyway. But at least if user has gksu installed there will be no ask to choose su_cmd, otherwise user will be prompted in preferences window to enter it.
    And if user is administrator he/she will understand the meaning of that error message but if user doesn't understand it then I think user will break his system doing something he/she doesn't understand. I believe there is no real need to open any folder as root if you aren't administrator of multi-user system. And even furthermore - open folder as root in GUI application is very dangerous and if you ask me I would vote to remove such possibility from the file manager. It's probably why there is no other file manager which has such hacker's function. :)
    So in short - if you still think the default should be removed then let do it sometime later. We'll discuss it between developers though if that function should be available in non-advanced mode at all.
    Thank you very much!

     
    • milestone: 3172103 --> 2334041
    • status: open-fixed --> open-later
     
    • milestone: 2334041 --> 1.2
    • status: open-later --> closed-fixed
     
  • We hope this issue is completely fixed in the Git repository recently:
    'Open as root' will be not included into main menu in pcmanfm version 1.2 anymore, it will be in context menu as user script therefore no 'su_cmd' option in config.
    See http://wiki.lxde.org/en/PCManFM for details about the user script.
    Thank you very much.