#598 data loss during cut and paste to full drive

1.0.1
closed-fixed
libfm (217)
8
2012-09-09
2012-09-08
karl anliot
No

i cut an pasted to a full disk, pcmanfm reported an error about "splicing files failed"
this resulted in signifigant data loss.
see the mv command for proper operation. pcmanfm should fail gracefully.

1 more time, i'm moving files with cut and paste, but the operation failed. although the operation failed, pcmanfm deleted my files. pcmanfm should not delete files that were not actually moved.

mount a disk with less than 100mB free.
launch pcmanfm, use the cut option on a folder with 200mb of files
navigate to the mounted disk, paste.
should not lose 100mb of files

Discussion

  • Thank you very much for detailed bug report!
    If I knew that loss is source directory deletion, not individual files then I would fix it earlier.
    We hope this issue is completely fixed in the Git repository recently.
    Check it out when it's possible for you and if the bug still exists then reopen the report, please.
    The fix will be in 1.0.1 release.

     
    • priority: 5 --> 8
    • assigned_to: nobody --> lstranger
    • labels: 2616493 --> libfm
    • milestone: --> 1.0.1
    • status: open --> closed-fixed
     
  • karl anliot
    karl anliot
    2012-09-09

    reopening as requested.
    http://imagebin.org/227748

    see above image, it shows the 0 byte files, not shown is the directory that was deleted, (because it's now deleted, and the data is lost)

     
  • karl anliot
    karl anliot
    2012-09-09

    • status: closed-fixed --> open-fixed
     
  • karl anliot
    karl anliot
    2012-09-09

    • status: open-fixed --> open
     
  • Have you reinstalled libfm from fresh sources from git? I've tested it thoroughly and now it should:
    1) remove destination files that not fully copied (such as zero-length ones);
    2) remove only those source files that successfully copied.
    Check your installation if you have recent library rebuilt, please. Thank you.

     
  • karl anliot
    karl anliot
    2012-09-09

    • status: open --> closed-fixed
     
  • karl anliot
    karl anliot
    2012-09-09

    ok tested with the commit from last night. no more bug. 100%
    cheers!