#564 Changing file attributes doesn't work as expected

1.0
closed-postponed
libfm (280)
5
2012-07-08
2012-07-08
Sworddragon
No

Since I'm using PCManFM changing file attributes was more an obstacle than a help. But after the latest changes on the menu it is getting worse. Here are a few examples:

The directory /srv/minecraft (with subcontent) has the following attributes:

User: sworddragon
Group: sworddragon
View content: Only owner
Change content: Nobody
Access content: Only owner

Setting "View content", "Change content" and "Access content" to Anyone and pressing OK doesn't ask me if I want to use this attributes recursively.

Next example with /srv/minecraft:

User: sworddragon
Group: sworddragon
View content: Anyone
Change content: Anyone
Access content: Anyone

Setting the user and group to root (this will popup the dialog which asks me to use the attributes recursively) and "View content", "Change content" and "Access content" to "Only Owner", pressing OK and confirming to use the attributes recursively will result in the following: For example ... ooops, the dialog to ask me to use the attributes recursively doesn't appear anymore as before in my tests (seems I have made something different but I don't remember anymore). I don't even know how to force this. I would say this is a bug and if this behaviour is wanted - it could look too much complicated and confusing for a normal user. Ok, let's reset anything with chown and chmod so I can get sure to get what I'm expecting: "chown -R sworddragon:sworddragon /srv/minecraft"; "chmod -R 0777 /srv/minecraft".

Ok, now again:
Setting the user and group to root (this will popup the dialog which asks me to use the attributes recursively) and "View content", "Change content" and "Access content" to "Only Owner", pressing OK and confirming to use the attributes recursively will result in the following: For example ... oh, no dialog again. /srv/minecraft has the attributes as expected but the directory /src/minecraft/world has still the attributes from the chmod/chown command.

What I wanted to test is the following: If PCManFM asks me to use the attributes recursively and I'm confirming this there are very often files which are having some different attributes.

Tested version of PCManFM for this post was 0.9.10-0+git120706.

Discussion

    • labels: --> libfm
    • milestone: --> 1.0
    • assigned_to: nobody --> lstranger
     
    • status: open --> pending-wont-fix
     
  • Change for 'Access Content' disables recursion since there is no attribute 'Access Content' for ordinary files which could be inside of directory. Therefore this is an ambiguous condition. So that is not bug but feature. If you change only 'View content' and 'Change content' access rights then those can still be applied recursively.

    If you think this is not very good design then probably it's possible to change it, feel free to make suggestions but any changes will most probably require some major redesign.

    About not all attributes are applied recursively - only those that are changed in dialog are changed in recursion. It's made such way you don't make undesired changes in recursion accidentally. If you again think that isn't good design then feel free to propose yours.

    Thank you very much.

     
  • Sworddragon
    Sworddragon
    2012-07-08

    I have some good ideas to improve this heavily. But I will need some time to prepare this feature request (with some pictures and a large description in a new ticket). But this will happen after the release of version 1.0. So I'm closing this ticket now.

     
  • Sworddragon
    Sworddragon
    2012-07-08

    • status: pending-wont-fix --> closed-postponed