[Pcgen-trackers] [ pcgen-Bugs-1687659 ] Eq Customizer ignores PLUS: Token restrictions after removal

[SourceForge.net <no...@so...>]

Bugs item #1687659, was opened at 2007-03-25 02:26
Message generated for change (Settings changed) made by karianna
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1687659&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Equipment/Weaponprof Support
Group: To be fixed For 5.16.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tom Parker (thpr)
>Assigned to: Tom Parker (thpr)
Summary: Eq Customizer ignores PLUS: Token restrictions after removal

Initial Comment:
Weapon Editor does not enforce PLUS when removing the + modifier.

e.g. you can:

Customize Longsword
 - Bane is not available
Make it +1
 - Bane is now available
Add Bane(Dragons)
Remove +1, leaving Bane
 - Except Bane should be illegal


----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2008-04-15 13:12

Message:
Logged In: YES 
user_id=252169
Originator: NO

Ah submitted by Tom, back to 6.0

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2008-04-15 13:05

Message:
Logged In: YES 
user_id=252169
Originator: NO

Can't see reason for it to be in 6.0, moving to 5.14 - K

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2007-04-25 15:09

Message:
Logged In: YES 
user_id=252169
Originator: NO

confirmed, code dealing with this is in Equipment.java, in particular the
method:

public void removeEqModifier(final EquipmentModifier eqMod, final boolean
bPrimary) {
  ..
  ..
  if (false)
    removeUnqualified(bPrimary); // TODO: used?
)

The removeUnqualified() method itself has a comment:

// The problem is that you have entries
// like the following for Adamantine:
// PRETYPE:Weapon,Metal !PRETYPE:Masterwork
// Which have nothing to do with the eqMod, so
// they are always going to fail and be removed.

// The entries in equip_enhancing are used by
// the GUI to know what to display, not for
// actual passesPreReq checks


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1687659&group_id=25576