[Pcgen-trackers] [ pcgen-Bugs-1941055 ] .MOD SOURCE display error

[SourceForge.net <no...@so...>]

Bugs item #1941055, was opened at 2008-04-12 16:46
Message generated for change (Comment added) made by eddyanthony
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1941055&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Other
Group:  	  To be fixed For 5.14
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eddy Anthony (eddyanthony)
Assigned to: James Dempsey (jdempsey)
Summary: .MOD SOURCE display error

Initial Comment:
I'm working with a source which MODs some types onto some RSRD feats and I noticed that in the feats tab when the view source preference is set 
to "Long" it showed the publisher of the set with the MOD in it not the 
original object publisher. When set to Short it is correct.

Setting the preference to Short uses the format: 
<SOURCESHORT>, <SOURCEPAGE>

Setting the pref to Long uses: 
<PUBNAMELONG> -  <SOURCELONG>, <SOURCEPAGE>

The SOURCELONG is correct but apparently PUBNAMELONG is being MODed on. 
This occures even if the MODed feats are in there own file with no 
source header.

----------------------------------------------------------------------

>Comment By: Eddy Anthony (eddyanthony)
Date: 2008-04-24 20:59

Message:
Logged In: YES 
user_id=886893
Originator: YES

It is true that the Campaign pcc are missing this data but I was using the
Complete set and that and the Partial sets it loads have the pub data.

I did some more testing with Armor Proficiency (Barding), it did not
display pub info when I moved it to the feats file (those feats do show pub
data) nor did it when I added a DESC tag (it didn't have one. I finally got
it to work when I .MODed a DESC tag on it. All of our standard feats have a
long DESC tag MODed on to it and it seems that only those feats that do
show the pub name.

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2008-04-24 19:25

Message:
Logged In: YES 
user_id=558288
Originator: NO

After some further research, at least part of this problem is a data
problem. The rsrd_campaign_no_psionics.pcc file does not have publisher
info in it, and thus you get the " - sourcename" display on the abilities
tab. If you switch to using the rsrd_basics.pcc file you get the correct
"Wizards of the Coast - Revised (v.3.5) System Reference Document,
Feats.rtf" display. I haven't checked other pcc files for the presence of
publisher info.

However, there is still a code problem. If you comment out the .MOD of one
of the feats at the end of the rsrd_feats.lst file, the publisher name is
lost and you just see "Revised (v.3.5) System Reference Document,
Feats.rtf"

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2008-04-24 11:04

Message:
Logged In: YES 
user_id=886893
Originator: YES

Hi James
Tried your experiment and I no longer see the PUBNAMELONG from the MOD
dataset, however I don't see the original PUBNAMELONG either but there is a
dash before the source name as if  it was attempting to display it but has
nothing to display.

I also noticed something else, in Long view most feats list the publisher
but a minority do not, they just list the source. The feat Armor
Proficiency (Barding), which is in file:
/data/d20ogl/srd35/basics/rsrd_feats_hidden2.lst, does not list the
publisher before the source.

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2008-04-24 08:27

Message:
Logged In: YES 
user_id=558288
Originator: NO

Eddy,

Is there a trick to this one? :) I tried it out by adding the following
tag
Alertness.MOD	TYPE:Foo
to a file with PUBNAMELONG:Foobar and then loading it with the RSRD. The
alertness feat showed up with the new type but with sourceformat of long it
still showed the original publisher.

Cheers,
James.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1941055&group_id=25576