From: SourceForge.net <no...@so...> - 2006-11-24 16:24:45
|
Bugs item #1602107, was opened at 2006-11-23 23:40 Message generated for change (Comment added) made by romanticfool You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1602107&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Other Group: To be fixed For 5.12 Status: Open Resolution: None Priority: 5 Private: No Submitted By: romanticfool (romanticfool) Assigned to: Aaron Divinsky (boomer70) Summary: Generating NPC doesn't always do so. Initial Comment: The new function in 5.11.2 known as New NPC does not always generate the NPC. I cannot find one reason or another as to why it does or does not -- there is not a reproducible error, at least that I can find, that would explain why it does create NPCs to my specifications sometimes and other times it does not. In fact, if it fails to create the NPC, it fails to add a new tabbed character at all, if that helps. As far as system specs go, its 3GB ram, Intel Core 2 Duo 2.33Ghz, Mac OS X 10.4.8 If I knew Java, I'd be helping with the code, but as I don't... I'll leave it up to the guys who know what they are typing. ---------------------------------------------------------------------- >Comment By: romanticfool (romanticfool) Date: 2006-11-24 10:24 Message: Logged In: YES user_id=1652825 Originator: YES Oh, and btw, all my tests are done after loading all of RSRD Okay, from my tests of generating >30 NPCs, there does not seem to be a correlation on the choices I choose and the choices that don't produce an NPC. However, I think I might have an idea as to where your problem is. Thanks to the randomness, certainly the generator at this state tries to pair up, lets say alignment chaotic evil with randomed class paladin. The generator doesn't like this, and so simply forgoes creating the NPC in its entirety. Something like this could be the cause. For now, a status bar showing at what point the NPC has been generated would be excellent, because depending on the randomed level of the NPC, the NPC generation can vary in large amounts of time. I will give the difference between a 'successful' generation and a generation that doesnt create the window. 'successful' generation of all any's: java.util.ConcurrentModificationException at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:449) at java.util.AbstractList$Itr.next(AbstractList.java:420) at pcgen.core.PlayerCharacter.getSkillPoints(PlayerCharacter.java:2770) at pcgen.gui.tabs.InfoSkills.getToDos(InfoSkills.java:293) at pcgen.gui.CharacterInfo.flagToDos(CharacterInfo.java:431) at pcgen.gui.CharacterInfo.access$500(CharacterInfo.java:55) at pcgen.gui.CharacterInfo$PcSetter.finished(CharacterInfo.java:472) at pcgen.util.SwingWorker$1.run(SwingWorker.java:107) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209) at java.awt.EventQueue.dispatchEvent(EventQueue.java:461) at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:3274) at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:176) at java.awt.EventDispatchThread.run(EventDispatchThread.java:110) java.awt.event.InvocationEvent[INVOCATION_DEFAULT,runnable=pcgen.util.SwingWorker$1@b1ab27,notifier=null,catchExceptions=false,when=1164383885352] on apple.awt.CToolkit@70d9d4 and yet another successful, although this one had some hang time after the first message on the console: Unable to select deity. Character does not qualify for any deities. Exception in thread "Thread-66" java.util.ConcurrentModificationException at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:449) at java.util.AbstractList$Itr.next(AbstractList.java:420) at pcgen.core.Skill.isClassSkill(Skill.java:269) at pcgen.core.Skill.costForPCClass(Skill.java:902) at pcgen.core.PlayerCharacter.getMaxRank(PlayerCharacter.java:5417) at pcgen.core.Skill.getTotalRank(Skill.java:607) at pcgen.core.PlayerCharacter.includeSkill(PlayerCharacter.java:12923) at pcgen.core.PlayerCharacter.addNewSkills(PlayerCharacter.java:11980) at pcgen.core.PlayerCharacter.populateSkills(PlayerCharacter.java:9591) at plugin.charactersheet.gui.SkillsPane.refresh(SkillsPane.java:318) at plugin.charactersheet.gui.Page1Panel.refresh(Page1Panel.java:201) at plugin.charactersheet.gui.CharacterPanel$Refresher.refresh(CharacterPanel.java:594) at plugin.charactersheet.gui.CharacterPanel$Refresher.run(CharacterPanel.java:579) unsuccessful npc generation on any's: 2 of these at the beginning, and then after 40 more tries, i havent gotten another. I'm not sure if thats just the function of luck, or a function of how many other characters are opened. okay, i've gotten a reproducible error settings: neutral evil, human, warrior, and then specify the level as 2 the console displays this, and no character is created. java.lang.NullPointerException at pcgen.core.npcgen.NPCGenerator.getLevel(NPCGenerator.java:278) at pcgen.core.npcgen.NPCGenerator.generate(NPCGenerator.java:573) at pcgen.gui.PCGen_Frame1.doNewNPC(PCGen_Frame1.java:1279) at pcgen.gui.PCGen_Frame1.newNPCItem_actionPerformed(PCGen_Frame1.java:1294) at pcgen.gui.FrameActionListener$9.actionPerformed(FrameActionListener.java:139) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1882) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2202) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:420) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:258) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:234) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:232) at java.awt.Component.processMouseEvent(Component.java:5554) at javax.swing.JComponent.processMouseEvent(JComponent.java:3126) at java.awt.Component.processEvent(Component.java:5319) at java.awt.Container.processEvent(Container.java:2010) at java.awt.Component.dispatchEventImpl(Component.java:4021) at java.awt.Container.dispatchEventImpl(Container.java:2068) at java.awt.Component.dispatchEvent(Component.java:3869) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4256) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3936) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3866) at java.awt.Container.dispatchEventImpl(Container.java:2054) at java.awt.Window.dispatchEventImpl(Window.java:1774) at java.awt.Component.dispatchEvent(Component.java:3869) at java.awt.EventQueue.dispatchEvent(EventQueue.java:463) at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:3274) at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:176) at java.awt.EventDispatchThread.run(EventDispatchThread.java:110) java.awt.event.MouseEvent[MOUSE_RELEASED,(40,59),button=1,modifiers=Button1,clickCount=1] on frame1 However, change the level to any (1-20) and it works every time. So i believe that the error has to do with the level generation choices. It seems that no matter which level i choose, so long as its one of the explicit levels, the error console code pretty much matches the top, and its only on those that i seem to be having problems. Note: During one trial, the NPC generator failed to select a race, but gave it 19 (Any 1-20) levels in fighter. It didn't output an error message and console.log didnt push anything either, and it generated the character without a race. So that's strange. ---------------------------------------------------------------------- Comment By: Aaron Divinsky (boomer70) Date: 2006-11-24 09:33 Message: Logged In: YES user_id=1249558 Originator: NO Since this is definately alpha code the error handling is not up to scratch just yet. I would be helpful if you could tell me what options you had selected when it failed to generate an NPC. Also if you can check the console window (the command prompt that runs behind PCGen) and see if anything is printed out there. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2006-11-24 05:14 Message: Logged In: YES user_id=208239 Originator: NO This would be your NPC generator.... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1602107&group_id=25576 |