[Pcgen-trackers] [ pcgen-Feature Requests-1262306 ] Ability Object: Add Tag Category

[SourceForge.net <no...@so...>]

Feature Requests item #1262306, was opened at 2005-08-17 17:01
Message generated for change (Comment added) made by nuance
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262306&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tag modification
Group: None
Status: Open
Resolution: None
Priority: 8
Submitted By: Devon Jones (soulcatcher)
Assigned to: Andrew Wilson (nuance)
Summary: Ability Object: Add Tag Category

Initial Comment:
Category would probably just be a standard string
property. Just something to keep the ability objects
segregated.
CATEGORY:[NAME]

It may be a good idea to alter the storage of loaded
ability objects to instead of keeping them in one lsit,
keep a hashmap of lists with the category as the key to
the hashmap.

If you need any guidance, contact me.
Devon

----------------------------------------------------------------------

>Comment By: Andrew Wilson (nuance)
Date: 2005-08-28 02:03

Message:
Logged In: YES 
user_id=41667

src/java/pcgen/core/Globals.java 1.690
src/java/pcgen/core/PObject.java 1.724
src/java/pcgen/io/PCGVer0Parser.java 1.176
src/java/pcgen/io/PCGVer2Parser.java 1.169

Eliminated getFeatKeyed from Globals.java and every class
that called it.  Replaced with calls to Globals.getAbilityKeyed

----------------------------------------------------------------------

Comment By: Andrew Wilson (nuance)
Date: 2005-08-27 16:29

Message:
Logged In: YES 
user_id=41667

src/java/pcgen/core/Globals.java                1.689
src/java/pcgen/core/LevelAbilitySpecial.java    1.52
src/java/pcgen/core/PObjectUtilities.java       1.7
src/java/pcgen/core/PlayerCharacter.java        1.1508
src/java/pcgen/gui/tabs/InfoFeats.java          1.63

Added canSelectAbility to PlayerCharacter.java to factor
out some common tests from PObjectUtilities.java and
LevelAbilitySpecial.java

Eliminated methods getFeatListFeat and
getFeatListFeatString from Globals.java and everywhere
that called them.

Renamed some varibles in LevelAbilitySpecial.java and
InfoFeats.java to make the code clearer.

----------------------------------------------------------------------

Comment By: Andrew Wilson (nuance)
Date: 2005-08-26 03:26

Message:
Logged In: YES 
user_id=41667

src/test/pcgen/PCGenTestCase.java 1.5
src/test/pcgen/core/GlobalsTest.java 1.9
src/test/pcgen/util/testchecker/CompareGreaterOrEqual.java 1.1
src/test/pcgen/util/testchecker/CompareLessOrEqual.java 1.1

Did actually need >= and <= tests, so added Testchecker
classes to deal with them.  Made relevant changes to
PCGenTestCase.java.

Converted exisiting pcgen/core/GlobalsTest.java to use is
instead of assertTrue since the diagnostic messages are
better.

Added tests for the new methods to handle Abilities in
Globals.  Although these are not he final versions of
these methods, their interface should be stable and these
test should continue to work.

----------------------------------------------------------------------

Comment By: Andrew Wilson (nuance)
Date: 2005-08-26 03:15

Message:
Logged In: YES 
user_id=41667

src/java/pcgen/core/Ability.java 1.4
src/java/pcgen/core/Globals.java 1.688

Added very simple setter getter methods for category to
Ability. This still needs The loaders (LST and Character)
modified to
handle the category.

Added interim implementations of the new Ability methods to
Globals.java. These still use the ArrayList, when all of the
code that access the ArrayList directly has been rewritten,
these will be converted to use HashMaps.

----------------------------------------------------------------------

Comment By: Andrew Wilson (nuance)
Date: 2005-08-25 22:48

Message:
Logged In: YES 
user_id=41667

committed first change for this

pcgen/src/java/pcgen/core/Ability.java 1.3

basic tidying of Ability.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262306&group_id=25576