Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1167 Phantom groups listed in the main window

v1.0_(example)
closed
nobody
None
7
2014-07-15
2014-02-26
ttheis
No

Linux 0.93 beta on Linux Mint 13 MATE
Phantom groups listed in the main window. They are empty (have no entries under them). They have almost the same name as the valid group just above or below them. Sometimes the name is truncated sometimes a single period is appended to the end of the group name. (See attachment) They seem to change if you add or delete entries. The old phantom group would go away and a new one would show up after an add or deletion. No way to delete them perminately. Can rename them however. Did not happen in 0.92 beta.

1 Attachments

Discussion

1 2 > >> (Page 1 of 2)
  • Johan Vromans
    Johan Vromans
    2014-03-04

    Same here, Linux 0.93 beta on Fedora Linux 17.

     
  • Johan Vromans
    Johan Vromans
    2014-03-05

    I just noticed that in the Properties window, in the line "Last saved by:" the last character of the user name and hostname are missing. E.g., "fo on example.co" instead of "foo on example.com". This is probably related.

    Anyway, I downgraded to 0.92.

     
  • Saurav Ghosh
    Saurav Ghosh
    2014-03-05

    Is there a sequence of steps I can follow to reproduce this? tried everything I could think of to create a group without entries, but they are removed immediately on my system/build (Ubuntu). I never see any empty or phantom groups.

    If you provide a consistent set of steps to reproduce this, that would be helpful.

     
    • Johan Vromans
      Johan Vromans
      2014-03-05

      "Saurav Ghosh" sauravg@users.sf.net writes:

      Is there a sequence of steps I can follow to reproduce this? tried
      everything I could think of to create a group without entries, but
      they are removed immediately on my system/build (Ubuntu). I never see
      any empty or phantom groups.

      If you provide a consistent set of steps to reproduce this, that would
      be helpful.

      I have a keyring with some 250 entries, divided over 8 groups.

      With 0.92, no problem.

      I upgraded to 0.93 and added a new entry in one of the groups.

      I saved the keyring and exit pwsafe.

      Upon restart, it shows the 'phantom groups'.

      -- Johan

       
  • Saurav Ghosh
    Saurav Ghosh
    2014-03-06

    I have attached a somewhat large'ish safe. Can you please try to reproduce in that and let me know exactly under which group(s) I should create/remove entries to reproduce the problem? Password for the safe is Sample123.

    Thanks.

     
    Attachments
    • Johan Vromans
      Johan Vromans
      2014-03-06

      "Saurav Ghosh" sauravg@users.sf.net writes:

      I have attached a somewhat large'ish safe. Can you please try to
      reproduce in that and let me know exactly under which group(s) I
      should create/remove entries to reproduce the problem? Password for
      the safe is Sample123.

      For a start:

      run pwsafe with the sample database.

      File > Properties

      shows: Last saved by: sghosh on neptune

      File > Save As xx

      File > Exit

      run pwsafe with the xx database

      File > Properties

      shows: Last saved by: j on phoenix.squirrel.n

      This should be "jv on phoenix.squirrel.nl"

      -- Johan

       
  • Saurav Ghosh
    Saurav Ghosh
    2014-03-06

    Yes, I can reproduce that problem even on Ubuntu 13.10, Must be a regression. Not sure if that's the same as the phantom groups problem, but definitely looks serious enough to be fixed. I will work on it. Thanks for reporting!

     
  • Rony Shapiro
    Rony Shapiro
    2014-03-06

    Don't think the File->Properties issue's directly related, but note that I've just fixed an unrelated issue there (properties.cpp) in commit 70a125 (assert in 64bit build).

     
  • ttheis
    ttheis
    2014-03-06

    I can confirm I have two passwordsafe db's that have over 200 entries each. I see the problem in both. I even have sub groups under groups and the phantom directores also appear under the sub groups. Usually only one per group level however.

    I can't confirm the history deal as I have that feature turned off.

     
  • Saurav Ghosh
    Saurav Ghosh
    2014-04-02

    Can you please see if the attached patch fixes this issue? It should at least fix the issue with File => Properties that Johan mentioned in his last post.

    This basically undo'es the fix for 1150 (which I don't know how to reproduce) and then fixes it in a different way, so those guys also need to "buy in" on this fix as well.

     
    Attachments
    • yshirman
      yshirman
      2014-04-04

      I have applied the patch and tested whether the new fix for 1150 works on android. It mostly does but brings back a smaller bug/annoyance. 1150 actually solved two problems: the extra null character in the password that prevented copy&paste from working on android, and incorrect display of group with subgroups.

      The new fix work for the first issue but brings back the second one.
      Here is what is the problem: let's say I have a group (call it groupA) which contains inside one or more subgroups as well as ungrouped passwords. On android issue 1150 (and now the modified fix) resulted in the fact that groupA would be displayed twice: one copy would contain ungrouped passwords and a second copy would contain subgroups (and their passwords). There is also no indication which version of the group contains passwords and which contains subgroups. While more of an annoyance, it would still be great if that could be fixed.

       
      • Saurav Ghosh
        Saurav Ghosh
        2014-04-08

        It will be fixed. That’s why the fix for 1167 is not checked in yet. I needed someone to tell me that that fix doesn’t re-introduce 1150, or a part of it.

        Can you please clarify what the exact repro for 1150 is? I see a password db attached, but I’m not sure how to repro the problem with that db. I’m OK with a repro either on a desktop/laptop or on android with the latest version of the app.

        Thanks,
        Saurav.

         
        • yshirman
          yshirman
          2014-04-09

          After looking at your version of the fix, I'm not sure that the sample db attached to my original 1150 posting is sufficient to see the problem...

          With the sample database: open it in android version of passwordsafe (the app by Jeff Harris the app name is passwdsafe). Go to edit password mode and count the number of asterisks representing individual characters in the password: you'll see that there is one more character than in the password itself.
          When a real db with a real password is used, the password does not match when pasted into an appropriate passwordbox.
          According to Jeff Harris this due to the additional character which is \0 and which is being interpreted by android as a regular utf-8 character.

          Unfortunately, counting characters in editing mode on android is the only way I know how to see the bug when using the sample db.
          The reason that the sample db may not be sufficient to see the problem is the following: your version of the solution also shows an additional character when editing password on android side. However, when a real password is pasted into an appropriate password box, it works. (For completeness: Rony's fix implemented in 0.93 shows as many asterisks in editing mode as there are characters in a password.)

          So to be sure to reproduce the bug, I would create a db with some real password using Linux passwordsafe versions 0.91 or 0.92 (I believe 0.93 already has Rony's fix) and try to use it on android side. The way I checked your fix was by actually using on android a real/valid password from a db file created with a patched version on Linux.

           
  • Johan Vromans
    Johan Vromans
    2014-04-02

    [Quoting Saurav Ghosh, on April 2 2014, 05:50, in "[passwordsafe:bugs] "]

    Can you please see if the attached patch fixes this issue? It should at least
    fix the issue with File => Properties that Johan mentioned in his last post.

    Applied to 0.93BETA and it seems to fix it.

    I also didn't get any phantom groups after making some changes to the keyring entries, so this may be fixed as well...

    I still can add/modify entries while in readonly mode. I thought this
    was fixed in 0.93?

    Thanks for the good work!

    -- Johan

     
    Last edit: Johan Vromans 2014-04-02
    • Saurav Ghosh
      Saurav Ghosh
      2014-04-02

      I still can add/modify entries while in readonly mode. I thought this
      was fixed in 0.93?

      I’m sure this fix has nothing to do with that bug, but I’ll take a look at that too. Do you have the bug number?

       
      • Johan Vromans
        Johan Vromans
        2014-04-02

        "Saurav Ghosh" sauravg@users.sf.net writes:

        I still can add/modify entries while in readonly mode. I thought this
        was fixed in 0.93?

        I’m sure this fix has nothing to do with that bug,

        Yes -- sorry if I made you think it was related.

        but I’ll take a
        look at that too. Do you have the bug number?

        1. The subject is not quite correct, the text is.

        In short, even in readonly mode the menu entries Edit > New Entry and
        Delete Entry are available and functional, except that the changes are
        silently discarded.

        When fixing 'readonly' code you may want to look at 1159 as well.

        Thanks a lot!

        -- Johan

         
  • Saurav Ghosh
    Saurav Ghosh
    2014-04-16

    Here's the new patch for 1150 as well as 1167. This pretty much ensures that pwsafe doesn't write any extraneous terminating NULL chars at the end of any of the text fields. Note that this undo'es the fix for 1150, so folks who had that problem should also test this patch.

    Please remember to apply this to clean 0.93 codebase (i.e. without any other patches from earlier).

    If it still doesn't work, please let me know if the db you are testing with was created on Android, pwsafe-linux-0.92, pwsafe-linux-0.93, windows or something else.

     
    • yshirman
      yshirman
      2014-04-16

      I downloaded 0.93 srpm, applied patch and built the patched pwsafe. I then opened my existing psafe3 file, changed one password, saved the file, reopened it changed the password back, saved again. I copied the new psafe3 file to android and tried it out -- all seems to work as far as 1150 is concerned: folder display is correct, password works, the number of asterisks in the edit view is the same as number of characters in the password.

       
  • ttheis
    ttheis
    2014-04-16

    I am the origial poster on this and I would love to try this patch out. However I have no experience in doing the patch deal. I just download the passwordsafe-ubuntu-0.93BETA.amd64.deb file and install it. Can someone help here?

     
    • Saurav Ghosh
      Saurav Ghosh
      2014-04-16

      Applying the patch requires building pwsafe from source code. First, you’ll need to get the sources. There are two options:

      1. Download http://sourceforge.net/projects/passwordsafe/files/Linux-BETA/0.93/pwsafe-0.93BETA-src.tgz

      You’ll need to expand this archive somehow. In a terminal, you can do this:

      tar xzf pwsafe-0.93BETA-src.tgz
      cd pwsafe-0.93BETA

      1. The other way to get the source code is to check it out from the repository:

      git clone https://ttheis@git.code.sf.net/p/passwordsafe/git-code passwordsafe-git-code
      cd passwordsafe-git-code

      and then make it the same as 0.93 beta:

      git checkout -b 1167fix 0.93BETA

      Then you’d need to apply the patch attached to my previous post. Download the file "0001-Discard-terminating-NULL-chars-for-text-fields.patch” and do this:

      git apply 0001-Discard-terminating-NULL-chars-for-text-fields.patch

      Then you’ll need to build pwsafe. Build instructions are in README.LINUX.DEVELOPERS.TXT file in sources.

      Sorry if the instructions are too verbose. I don’t know how comfortable you are with all this. May be this would help someone else if not you.

       
  • ttheis
    ttheis
    2014-04-16

    Saurav;

    Thanks for the instructions. While I think I might be able to power through this procedure I am short on time right now and I know the trial and error time will take me quite a while. On top of that I would never be sure I did every step correctly. So unless someone else can create a patched passwordsafe-ubuntu-0.93BETA.amd64.deb without the Yubikey support I will have to wait for the final product.

    Thanks again.

     
  • Rony Shapiro
    Rony Shapiro
    2014-05-12

    • status: open --> pending
     
  • Rony Shapiro
    Rony Shapiro
    2014-05-12

    Saurav's fix accepted and applied to all platforms, not only Linux (after testing).
    Commit 5401a0d, will be in next release.

     
  • ttheis
    ttheis
    2014-05-12

    Thanks for all the work on this. I look forward to the next release.

    Additionally I also noticed an extra character at the end of a passowrd when pasted into a field. It is not a null character however. I pasted into vim set up as a hex editor and the character is a hex 0A. Just my two cents.

     
    • Saurav Ghosh
      Saurav Ghosh
      2014-05-13

      Please file a bug on this if if you can reproduce it with a build that has the final fix for 1167.

      Note that you would need to slightly change the pwsafe db entry you were working with and save the password db with the build for the fix to have any effect. In my testing, the fix only mattered for entries that I modified & saved. Its not enough to just save the entire db. pwsafe will only re-write those entries which actually changed. So you need to change the problematic entry slightly.

      Conversely, the “extra null char at end of password” problem only affects those entries that you saved with a build that had that problem. Its not necessary that all your entries have an extra null in the password field, and that’s probably the reason you might not have noticed it all the other entries.

      On 13-May-2014, at 1:19 am, ttheis ttheis@users.sf.net wrote:

      Additionally I also noticed an extra character at the end of a passowrd when pasted into a field. It is not a null character however. I pasted into vim set up as a hex editor and the character is a hex 0A. Just my two cents.

       
1 2 > >> (Page 1 of 2)