Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1063 Unable to create intermediate backup in Password Safe 3.29

v1.0_(example)
pending
Rony Shapiro
path (1)
1
2012-10-04
2012-10-04
Matt
No

I believe I've found the cause to this problem in version 3.29. I'm not sure if the problem carried over from previous versions (i.e. 3.26) but I've done some thorough testing of version 3.29 to figure out why I was getting the 'Unable to create intermediate backup' error.

As you'll see in my attached PDF, I believe what is happening is that the OPEN FILE/CLOSE FILE programming code isn't taking into consideration the directory within the path of the psafe3 file that is opened. The OPEN FILE program code is not as picky as the CLOSE FILE code since the file actually opens. However, when the CLOSE FILE command is issued, it errors out because it cannot locate the actual path of the original file as it appears it was not captured upon opening the file.

I hope my research helps to plug this hole and resolves the problem for good. :)

1 Attachments

Discussion

<< < 1 2 (Page 2 of 2)
  • Matt
    Matt
    2012-10-05

    Hi Rony,
    I'm in the middle testing now, but could I possibly ask for the md5 hash for this just to ensure I'm getting a 1-for-1 copy of the file please, if it's not too much to ask. I want to make sure my dl didn't get screwed up in mid-flight as well (not that it has anyway). It would be a disservice if I'm testing something that isn't 100% what you intended.

    Thanks,
    -Matt

     
    • Rony Shapiro
      Rony Shapiro
      2012-10-05

      The md5 sum of the zip file I uploaded is 50599944db0d72faf0a204b21b7e3d0c

       
  • Matt
    Matt
    2012-10-05

    Ok, I went ahead and did my testing because I was anxious to see the results, and from the stand point of my findings, the changes have made it bulletproof. :) I now no longer get the error, and every attempt to reproduce the problem couldn't be done. Now when I open pwsafe with the file name (only), or using a relative path, it puts the full path in the 'Open Password Database' field. Perfect!

    So I believe you've fixed the problem for a lot of people based on the multiple entries I've seen posted in the support request page.

    Out of curiosity, do you know if this problem persisted throughout the earlier versions? The reason I ask is because I did see a lot of people getting the same error with multiple earlier versions.

    Thanks so much Rony for your help with this. Love to see developers that are uber responsive like this. It goes along way to building great street cred.

    I will be posting a very positive review on this software in the near future.

    (p.s. Would you mind shooting me an email describing where you made the changes to the code? I would really like to see how you did it as I'm interested in learning to code more effectively. Even if you just tell me the files you changed, I can look for the differences. If you are too busy or can't be bothered to do so, no worries, just thought I'd ask.)

     
    Last edit: Matt 2012-10-05
  • Rony Shapiro
    Rony Shapiro
    2012-10-05

    Glad to see the fix works for you.
    I have to admit - without your help in reporting this in such detail, I would never have nailed it down.
    The change I made was trivial, just called a function to 'normalize' the filename to an absolute path. Unfortunately, there's an issue with SourceForge's repository right now, so I can't point you to the exact change, but the main file changed is src/ui/Windows/ThisMfcApp.cpp, in the command-line argument parsing.
    As this code's pretty old, I think we can safely assume that you've nailed this problem for all the related tickets, which I'll be updating later.
    Again, thanks for putting in time to track this down.

    Rony

     
  • Rony Shapiro
    Rony Shapiro
    2012-10-06

    • status: open --> closed
     
<< < 1 2 (Page 2 of 2)