Re: [Pam-patches] Change in review policy?

[Tomas M. <tm...@re...>]

On Tue, 2007-12-04 at 11:01 +0100, Thorsten Kukuk wrote:
> On Tue, Dec 04, Tomas Mraz wrote:
> > On Tue, 2007-12-04 at 09:13 +0100, Thorsten Kukuk wrote:
> > > On Tue, Dec 04, Tomas Mraz wrote:
> > > 
> > > > It seems to me that our current policy of no commit without review is
> > > > showing its limits. Recently there was no reply to many patches sent to
> > > > the list. 
> > > 
> > > Yes, I was on travel for nearly two weeks and have still some hundred
> > > mails to read ...
> > >  
> > > > Shouldn't we change the policy so we can commit - say after 3 or 5 days
> > > > if no review/objections are sent to the mailing list? We can revert
> > > > changes later if there appear new objections after the commit.
> > > > Of course we should keep the requirement to send any substantial patch
> > > > to this mailing list.
> > > 
> > > Maybe something like: send a reminder after X days, and if nobody
> > > answers, commit after Y days.
> > Yes, that seems to be a good proposal. Now we should setup some values
> > of X and Y - I propose X=4 and Y=4 so that's more than a week for reply.
> 
> I think X=4 and Y=3 are enough, that's one week.
OK. So be it.

> > We could also establish a practice that if we are leaving for more than
> > a week for holidays we could send a notice in advance to the list so the
> > author of the patch will wait for the reply after the person on holidays
> > will return.
> 
> I think there are enough people on this list, so that it should not matter
> if one person isn't available.
Well there didn't seem to be many reviews besides yours and mine
recently.

> While it is a good idea to send a message, it is, like in my case now,
> not always doable (for example if you have to leave on very short notice).
> 
> But we can try to send such a message in the future.
One would send the message only if he wanted to delay committing
eventual patches which would be sent to the mailing list during his
leave. So this message is definitely optional and as I said above we can
always revert a patch in CVS later.

-- 
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
                                              Turkish proverb