#25 property name mismatches

open
Rogan Dawes
5
2008-02-13
2008-02-13
Pavel Kankovsky
No

Class org.owasp.webscarab.ui.swing.Lite:
- method createNewSession gets WebScarab.DefaultDir (like everyone else) but it sets WebScarab.defaultDirectory later

Class org.owasp.webscarab.ui.swing.UIFramework
- method createNewSession sets WebScarab.defaultDirectory

Class org.owasp.webscarab.plugin.sessionid.swing.SessionIDPanel
- method exportButtonActionPerformed gets and sets WebScarab.DefaultDirectory

Class org.owasp.webscarab.plugin.proxy.BeanShell...
- method parseProperties gets BeanShell.scriptFile
- method setScriptFile sets BeanShell.scriptfile

Class org.owasp.webscarab.plugin.extensions.swing.ExtensionsPanel
- method loadButtonActionPerformed gets Extensions.DefaultDir but it sets Scripted.DefaultDir later

Again, I found it (perhaps I should say I stumbled upon it) when I was reading the source code.

BTW: Is there any reason why certain classes (namely org.owasp.webscarab.ui.swing.Lite, org.owasp.webscarab.ui.swing.UIFramework, and org.owasp.webscarab.plugin.proxy.swing.ManualEditFrame)
call Preferences.getPreferences().[gs]etProperty rather than Preferences.[gs]etPreference()?

Discussion

  • Rogan Dawes
    Rogan Dawes
    2008-02-13

    Logged In: YES
    user_id=438260
    Originator: NO

    Thanks for these bug reports.

    No, there is no good reason to use [gs]etProperty rather than [gs]etPreference, probably just carelessness.

    Can I suggest that we take this discussion to the mailing list?

    owasp-webscarab@lists.owasp.org

    Thanks!

    Rogan