Re: [Ortcan-devel] requestForMerging_kubaspet1Branch

[<kub...@fe...>]

Hello all,
sorry for the delay. I was busy.

1) Problem with Java compatibility:
Incompatibility with the Java 1.4 was caused using of "ENUM" types.  
Now it is working.

2) Problem with GUI exception:
This problem was caused incorrect using of GUI library. Now it is working.

The fixed code is in the branch "kubaspet2".
I would like to merge the branch "kubaspet2".

Thank all
Petr Kubasta



Quoting Pavel Pisa <pi...@cm...>:

> Hello all,
>
> the first, thank much to Petr Kubasta for his contribution
> and to Fanda Vacek for review. I have pulled kubaspet1
> branch to the master.
>
> I have observed problems to compile updated
> version. This has been resolved but there is yet another
> problem where I have not succed and reverted "master"
> back to state before changes.
>
> The environment used for testing
>
> javac 1.6.0_26 compiler
> java version "1.6.0_24"
> and
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02, mixed mode)
>
> on debian "lenny" and Debian "unstable".
>
> Then I tried java-7-openjdk on Debian "unstable"
>
> javac 1.7.0_03
> java version "1.7.0_03"
> OpenJDK Runtime Environment (IcedTea7 2.1.1pre) (7~u3-2.1.1~pre1-2)
> OpenJDK 64-Bit Server VM (build 22.0-b10, mixed mode)
>
> The first problem is that updates have made code noncompatible
> with Java 1.4 language version selected by OrtCAN ANT build.
>
> I have updated source language version to 1.5
>
> diff --git a/canmonitor/build.xml b/canmonitor/build.xml
> index 786f5c7..f5ece2c 100644
> --- a/canmonitor/build.xml
> +++ b/canmonitor/build.xml
> @@ -61,7 +61,7 @@
>          </copy>
>          <javac srcdir="${src}" destdir="${class}"
>              classpath="${jar.jdom}:${jar.ui}"
> -            source="1.4"
> +            source="1.5"
>              debug="true"
>              optimize="false"
>              includes="${path.monitor}/CanMonitor.java"
> @@ -115,7 +115,7 @@
>          <javac srcdir="${src}" destdir="${class}"
>              debug="true"
>              optimize="false"
> -            source="1.4"
> +            source="1.5"
>              includes="${path.cpickle}/CPickle.java"
>              />
>      </target>
>
> Code compiles but there is raised exception after EDS file selection
> confirmation.  I have tried to select different language level (1.6.)
> and different JAVA compiler environment but nothing has lead to
> behavior change.
>
> Next exception is reported
>
> nMonitor.conf.xml'
> asserts enabled: true
> Logging level: 1
> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
>         at  
> ocera.rtcan.monitor.CANopenDevicePanel.initGui(CANopenDevicePanel.java:179)
>         at  
> ocera.rtcan.monitor.CANopenDevicePanel.<init>(CANopenDevicePanel.java:124)
>         at ocera.rtcan.monitor.CanMonitor.openEDS(CanMonitor.java:346)
>         at ocera.rtcan.monitor.CanMonitor.access$000(CanMonitor.java:56)
>         at  
> ocera.rtcan.monitor.CanMonitor$1.actionPerformed(CanMonitor.java:272)
>         at org.jx.xmlgui.XMLAction.actionPerformed(XMLAction.java:20)
>         at  
> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
>         at  
> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
>         at  
> javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
>         at  
> javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
>         at  
> javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
>         at  
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
>         at java.awt.Component.processMouseEvent(Component.java:6505)
>         at javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
>         at java.awt.Component.processEvent(Component.java:6270)
>         at java.awt.Container.processEvent(Container.java:2229)
>         at java.awt.Component.dispatchEventImpl(Component.java:4861)
>         at java.awt.Container.dispatchEventImpl(Container.java:2287)
>         at java.awt.Component.dispatchEvent(Component.java:4687)
>         at  
> java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
>         at  
> java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
>         at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
>         at java.awt.Container.dispatchEventImpl(Container.java:2273)
>         at java.awt.Window.dispatchEventImpl(Window.java:2713)
>         at java.awt.Component.dispatchEvent(Component.java:4687)
>         at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:707)
>         at java.awt.EventQueue.access$000(EventQueue.java:101)
>         at java.awt.EventQueue$3.run(EventQueue.java:666)
>         at java.awt.EventQueue$3.run(EventQueue.java:664)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at  
> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
>         at  
> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
>         at java.awt.EventQueue$4.run(EventQueue.java:680)
>         at java.awt.EventQueue$4.run(EventQueue.java:678)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at  
> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
>         at java.awt.EventQueue.dispatchEvent(EventQueue.java:677)
>         at  
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:211)
>         at  
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
>         at  
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
>         at  
> java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
>         at  
> java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
>         at java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
>
> The run of GIT bisect suggests that problem appears in the commit
>
> 516653e7464aadd64b6c049159e5279a26925617 is the first bad commit
> commit 516653e7464aadd64b6c049159e5279a26925617
> Author: Kubasta Petr <kub...@fe...>
> Date:   Mon Apr 16 22:59:44 2012 +0200
>
>     add : jComboBox for choosing of representation
>
> I am not sure if the problem is caused by ANT build or specific
> JAVA compiler version or JAVA runtime environment. But it
> makes problem to both - old stable Debian and most current
> testing so I expect that it can be source of problems to
> other users as well. So I have reverted my pull to master
> at SF.net repository.
>
> I would appreciate much if the problem can be analyzed
> and solved at least for recent GNU/Linux distributions.
> I do not see problem with 1.5 or even 1.6 JAVA
> language level requirement (but not higher for now).
> But I prefer as wide as possible range of systems capable
> to run the CANmonitor application.
>
> Best wishes,
>
>               Pavel Pisa
>
> On Saturday 05 May 2012 14:33:24 Fanda Vacek wrote:
>> Ahoj,
>>
>> bohuzel se mi nepodarilo, odpovedet pomoci SF, mozna je to tim, ze nejsem
>> prihlasen k odberu tohoto mailing listu. Kazdopadne jsem rad, ze jste
>> tento projek posunul zase o kousek kupredu a s navrhovanymi zmenami
>> souhlasim.
>>
>> zdravi
>>
>> F. Vacek
>>
>> Hello, I have pushed some features in canmonitor in to branch "kubaspet1".
>> Description of features:
>>
>> It is working now:
>> - View and parsing of RAW HEX strings
>> - View and parsing of RAW BIN strings
>> - View and parsing by Type, for types: Integer, Unsigned, Real
>>
>>
>> Main changes:
>> a) View and model was separated. The class ModelViewTransformer was added.
>> b) Some files were added:
>>
>> RepresentationEnum - the enumerator for choose of view for jcombobox
>> InvalidTypeOfViewException - this class is representing exception for alert
>>
>> Can I request for merging with master branch?