Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

oprofile Log


Commit Date  
[d840b9] (23.6 kB) by Carl Love Carl Love , pushed by Maynard Johnson Maynard Johnson

Duplicate event specs passed to ocount show up twice in output

Invoking 'ocount' and passing an events list that contains
duplicate event specifications results in redundant data
collection. See the example below:

$ocount -e CPU_CLK_UNHALTED,CPU_CLK_UNHALTED /bin/true
Events were actively counted for 1192874 nanoseconds.
Event counts (actual) for /bin/true:
Event Count % time counted
CPU_CLK_UNHALTED 2,374,832 100.00
CPU_CLK_UNHALTED 2,374,832 100.00

The solution implemented with this patch is to store the input
event specs in a set, thus, exact duplicate event specs will be
automatically ignored.

Signed-off-by: Carl Love <cel@us.ibm.com>

2013-11-06 14:59:25 View
Download
[ebde58] (23.6 kB) by Maynard Johnson Maynard Johnson

Converge operf and ocount utility functions

When the ocount tool was developed, a number of utility
functions were needed that were very similar to operf utility
functions, with just minor changes. The decision was made at
the time to copy these functions into ocount and change them
as needed. To avoid dual maintenance on very similar functions,
we should converge the two tools to use one common set of utility
functions. The main reason for not doing so in the first place
was to make it easier to review ocount patches and not have to
look at operf changes at the same time.

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

2013-10-09 18:12:21 View
Download
[175ed4] (23.6 kB) by Maynard Johnson Maynard Johnson

Post-review fixups for new ocount feature

This patch fixes the issues raised during the review of the
'ocount' tool. Some of the issues were raised on the
oprofile-list, and some were raised internally by users
within my company. The issues raised internally were:
- Bug: Compile failure with recent gcc
- Request to display total time events were being counted in long output
- Bug: Counting multiple events in a run mode other than 'command [args]'
can result in incorrect output. For example:
ocount -s -e CPU_CLK_UNHALTED,UNHALTED_REFERENCE_CYCLES
Event counts (scaled) for the whole system:
Event Count % time enabled
CPU_CLK_UNHALTED 291,912,262 100.00
CPU_CLK_UNHALTED 27,431,626 100.00
- Bug: On ppc64 systems, event spec returned by _handle_powerpc_event_spec
may contain extra garbage after the event name.
- Request to change the --time-interval option to show counts just for
the interval, not cumulative counts

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

2013-07-18 18:45:02 View
Download
[5bcf38] (23.6 kB) by Maynard Johnson Maynard Johnson

Fix problems in ocount patch set found by Coverity

I ran Coverity against the oprofile source tree with the "ocount"
patch set applied, and it found several issues. This patch fixes
those.

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

2013-07-18 18:43:54 View
Download
[e83b4f] (23.1 kB) by Maynard Johnson Maynard Johnson

New ocount tool and associated ocount_counter classes

This patch implements the executable 'ocount' tool, as
well as some classes used for opening and managing the
"perf_events" file descriptors (opened via perf_event_open).

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

2013-07-18 18:42:14 View
Download